Add DCHECK in copy constructor of StyleVisualData for m_zoom.

Add DCHECK in copy constructor of StyleVisualData for m_zoom.

Currently StyleVisualData::m_zoom is reset to the initial zoom value
every time StyleVisualData is copied using the copy constructor. There
is no indication that this is intentional.

This patch adds a DCHECK to see if there's any case where we trigger
this bug. If not, we will copy m_zoom properly in a separate patch.

Not to be merged in.

BUG=689330
Review-Url: https://codereview.chromium.org/2687533004
Cr-Commit-Position: refs/heads/master@{#449215}
Committed: https://chromium.googlesource.com/chromium/src/+/4be275ae7e189294e00a1c65ec9976974b1329de

[shend, 2017-02-07 22:11:49]

Description was changed from

==========
Add DCHECK in copy constructor of StyleVisualData for m_zoom.

Currently StyleVisualData::m_zoom is reset to the initial zoom value
every time StyleVisualData is copied using the copy constructor. There
is no indication that this is intentional.

This patch adds a DCHECK to see if there's any case where we trigger
this bug. If not, we will copy m_zoom properly in a separate patch.

BUG=689330
==========

to

==========
Add DCHECK in copy constructor of StyleVisualData for m_zoom.

Currently StyleVisualData::m_zoom is reset to the initial zoom value
every time StyleVisualData is copied using the copy constructor. There
is no indication that this is intentional.

This patch adds a DCHECK to see if there's any case where we trigger
this bug. If not, we will copy m_zoom properly in a separate patch.

Not to be merged in.

BUG=689330
==========

[shend, 2017-02-07 22:12:13]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 22:13:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 00:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:07:23]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-02-09 03:12:56]

sashab@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2017-02-09 03:12:56]

Let's actually land this.

[shend, 2017-02-09 03:14:01]

On 2017/02/09 at 03:12:56, sashab wrote:
> Let's actually land this.

Like land it and see if it triggers in use?

[sashab, 2017-02-09 03:22:09]

Oh sorry, LGTM.

And, yes. :)

[sashab, 2017-02-09 03:24:57]

FYI -- we commonly land DCHECK-only patches just to assert functionality in the
wild. Eg https://codereview.chromium.org/2169453002,
https://codereview.chromium.org/1001323003

[shend, 2017-02-09 04:17:57]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-02-09 04:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 06:05:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486613877989240, "parent_rev":
"598043a9d645cec72159c5dac7f0b21ac29ca470", "commit_rev":
"4be275ae7e189294e00a1c65ec9976974b1329de"}

[commit-bot: I haz the power, 2017-02-09 06:07:12]

Description was changed from

==========
Add DCHECK in copy constructor of StyleVisualData for m_zoom.

Currently StyleVisualData::m_zoom is reset to the initial zoom value
every time StyleVisualData is copied using the copy constructor. There
is no indication that this is intentional.

This patch adds a DCHECK to see if there's any case where we trigger
this bug. If not, we will copy m_zoom properly in a separate patch.

Not to be merged in.

BUG=689330
==========

to

==========
Add DCHECK in copy constructor of StyleVisualData for m_zoom.

Currently StyleVisualData::m_zoom is reset to the initial zoom value
every time StyleVisualData is copied using the copy constructor. There
is no indication that this is intentional.

This patch adds a DCHECK to see if there's any case where we trigger
this bug. If not, we will copy m_zoom properly in a separate patch.

Not to be merged in.

BUG=689330

Review-Url: https://codereview.chromium.org/2687533004
Cr-Commit-Position: refs/heads/master@{#449215}
Committed:
https://chromium.googlesource.com/chromium/src/+/4be275ae7e189294e00a1c65ec99...
==========

[commit-bot: I haz the power, 2017-02-09 06:07:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4be275ae7e189294e00a1c65ec99...