Sprinkle some release asserts over HTMLFrameElementBase

Sprinkle some release asserts over HTMLFrameElementBase

It appears to be difficult to get this right, but it's quite bad if we
get it wrong, so rather crash.

BUG=628942
R=dcheng@chromium.org

Committed: https://crrev.com/b9e3d96067ff8c016d2505ab2a1f6b9d985c6b35
Cr-Commit-Position: refs/heads/master@{#407430}

[dominicc (has gone to gerrit), 2016-07-25 05:13:55]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 05:14:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 05:23:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 05:23:19]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[jochen (gone - plz use gerrit), 2016-07-25 06:39:28]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 06:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 06:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 06:48:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jochen (gone - plz use gerrit), 2016-07-25 06:56:46]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 06:56:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-07-25 07:41:37]

ptal - now with less redness

[dominicc (has gone to gerrit), 2016-07-25 07:43:59]

This is a bit subtle but I guess LGTM, seems like a way to find out more about
the problem and have crashing is a safer failure mode.

[jochen (gone - plz use gerrit), 2016-07-25 07:54:56]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-07-25 07:54:57]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-07-25 07:55:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 08:19:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-25 08:37:59]

Description was changed from

==========
Sprinkle some release asserts over HTMLFrameElementBase

It appears to be difficult to get this right, but it's quite bad if we
get it wrong, so rather crash.

BUG=628942
R=dcheng@chromium.org
==========

to

==========
Sprinkle some release asserts over HTMLFrameElementBase

It appears to be difficult to get this right, but it's quite bad if we
get it wrong, so rather crash.

BUG=628942
R=dcheng@chromium.org

Committed: https://crrev.com/b9e3d96067ff8c016d2505ab2a1f6b9d985c6b35
Cr-Commit-Position: refs/heads/master@{#407430}
==========

[commit-bot: I haz the power, 2016-07-25 08:38:00]

Patchset 3 (id:??) landed as
https://crrev.com/b9e3d96067ff8c016d2505ab2a1f6b9d985c6b35
Cr-Commit-Position: refs/heads/master@{#407430}

[tkent, 2016-07-26 08:02:02]

> Patchset 3 (id:??) landed as
https://crrev.com/b9e3d96067ff8c016d2505ab2a1f6b9d985c6b35
> Cr-Commit-Position: refs/heads/master@{#407430}

I'm afraid this made telemetry_perf_unittests crashy.

https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...

DevtoolsTargetCrashException: Devtools target crashed
 
********************************************************************************
 
(e:\b\swarm_slave\w\irkqrqwp\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_backend.py:410
_AddDebuggingInformation) Received a socket error in the browser connection and
the tab no longer exists. The tab probably crashed.
 
********************************************************************************
 
(e:\b\swarm_slave\w\irkqrqwp\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_backend.py:411
_AddDebuggingInformation) Debugger url:
ws://127.0.0.1:54787/devtools/page/5ab50a25-2804-451f-9b78-4979a95c0be7
  Found Minidump: True
  Stack Trace:
 
********************************************************************************
  	ChildEBP RetAddr  Args to Child              
  	0018c54c 67ef2af8 0018caa0 67ef58c7 0018c66c
chrome_child!base::debug::BreakDebugger+0x9
  	0018c554 67ef58c7 0018c66c 6a4114b8 5f72ca48
chrome_child!logging::InitChromeLogging+0x2f7
  	0018caa0 68aa8e37 5f72ca48 0018cca8 00000003
chrome_child!logging::LogMessage::~LogMessage+0x1c7
  	0018cbb4 68a5c656 5f72ca48 0018ccb8 689f018f
chrome_child!blink::HTMLFrameElementBase::isURLAllowed+0xd6
  	0018cbc0 689f018f 3954d738 0018cca8 5f72ca48
chrome_child!blink::HTMLIFrameElement::layoutObjectIsNeeded+0xb
  	0018cbd4 68972daa 5f72ca48 5f72ca48 00000000
chrome_child!blink::LayoutTreeBuilderForElement::shouldCreateLayoutObject+0x93
  	0018ccb8 68aa8c08 0018ccd8 5f72ca48 0018cce0
chrome_child!blink::Element::attachLayoutTree+0xad
  	0018ccc8 6894873c 0018ccd8 5f72ca48 3954d738
chrome_child!blink::HTMLFrameElementBase::attachLayoutTree+0xe
  	0018cce0 6897373f 0018ccf4 3954d738 00000000
chrome_child!blink::Node::reattach+0x44
  	0018ccfc 68979927 3954d738 00000004 5f72ca48
chrome_child!blink::Element::buildLayoutTree+0x3f

[jochen (gone - plz use gerrit), 2016-07-26 09:55:38]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2175313005/ by jochen@chromium.org.

The reason for reverting is: Unflake bots.

[jochen (gone - plz use gerrit), 2016-07-26 09:55:57]

On 2016/07/26 at 09:55:38, jochen wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2175313005/ by jochen@chromium.org.
> 
> The reason for reverting is: Unflake bots.

This is tracked in Issue 631330

[esprehn, 2016-11-12 09:46:52]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-11-12 09:46:53]

lgtm

[dcheng, 2016-11-12 18:14:11]

On 2016/11/12 09:46:53, esprehn wrote:
> lgtm

Did you look at https://codereview.chromium.org/2497133002/ as well, which is
the proposed reland? It's a bit more narrowly scoped, but in all the UXSSes I've
seen, the contentFrame() assert is the important one: that's why my reland only
includes it.