Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1001323003: Temporarily disable baseLayoutStyle optimization. (Closed)

Created:
5 years, 9 months ago by rune
Modified:
5 years, 9 months ago
Reviewers:
esprehn
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, dstockwell, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Temporarily disable baseLayoutStyle optimization. In order to figure out more about how the baseRenderStyle validity assert triggers in the wild, we'll try to temporarily make a RELEASE_ASSERT out of it. This means we'll effectively disable the optimization, yet clone a baseLayoutStyle to be able to check that the optimization would have been sound. Performance tests may intentionally degrade as a consequence. R=esprehn@chromium.org BUG=463413 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M Source/core/animation/ElementAnimations.cpp View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rune
This should not land before [1] to avoid known assertions. [1] https://codereview.chromium.org/1000413003/
5 years, 9 months ago (2015-03-13 13:29:07 UTC) #1
esprehn
lgtm
5 years, 9 months ago (2015-03-16 19:56:10 UTC) #2
rune
On 2015/03/16 19:56:10, esprehn wrote: > lgtm Thanks. I'll hold off landing until the known ...
5 years, 9 months ago (2015-03-16 21:46:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001323003/1
5 years, 9 months ago (2015-03-23 17:25:36 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 18:49:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192378

Powered by Google App Engine
This is Rietveld 408576698