Include metadata in AOT to expand inline frames in stack traces and provide line numbers.

Include metadata in AOT to expand inline frames in stack traces and provide line numbers.

Also fix stack trace collection to always include invisible frames. It can happen that a visible function is inlined into an invisible function, and we don't expand inlined frames until we print a stack trace.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/cfe5e5f075431641642a8e3be2fbd4414eaca1fd

[rmacnak, 2017-02-10 01:54:45]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[rmacnak, 2017-02-10 02:02:42]

Description was changed from

==========
Include metadata in AOT to expand inline frames in stack traces and provide line
numbers.
==========

to

==========
Include metadata in AOT to expand inline frames in stack traces and provide line
numbers.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624 (+16%)
Total(CodeSize): 17785396 (+12%)
==========

[rmacnak, 2017-02-10 02:13:33]

Description was changed from

==========
Include metadata in AOT to expand inline frames in stack traces and provide line
numbers.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624 (+16%)
Total(CodeSize): 17785396 (+12%)
==========

to

==========
Include metadata in AOT to expand inline frames in stack traces and provide line
numbers.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)
==========

[rmacnak, 2017-02-10 21:59:04]

Description was changed from

==========
Include metadata in AOT to expand inline frames in stack traces and provide line
numbers.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)
==========

to

==========
Include metadata in AOT to expand inline frames in stack traces and provide line
numbers.

Also fix stack trace collection to always include invisible frames. It can
happen that a visible function is inlined into an invisible function, and we
don't expand inlined frames until we print a stack trace.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)
==========

[rmacnak, 2017-02-11 00:50:39]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-02-11 03:19:00]

lgtm

https://codereview.chromium.org/2687143005/diff/60001/runtime/tests/vm/dart/o...
File runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart
(right):

https://codereview.chromium.org/2687143005/diff/60001/runtime/tests/vm/dart/o...
runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart:37: }
Does it make sense to extend your markers 'A,B,C etc. to the bottom
part of this file also?

https://codereview.chromium.org/2687143005/diff/60001/runtime/tests/vm/dart/o...
File runtime/tests/vm/dart/optimized_stacktrace_line_test.dart (right):

https://codereview.chromium.org/2687143005/diff/60001/runtime/tests/vm/dart/o...
runtime/tests/vm/dart/optimized_stacktrace_line_test.dart:37: }
Ditto comment about labeling the rest of the tests.

https://codereview.chromium.org/2687143005/diff/60001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2687143005/diff/60001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9093: Smi& token_pos = Smi::Handle(zone);
this smi could be hoisted above and shared with the smi used in the binary
search

https://codereview.chromium.org/2687143005/diff/60001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9124: return min + 1;
The + 1 here is because line numbers start from 1 ?

https://codereview.chromium.org/2687143005/diff/60001/tests/language/full_sta...
File tests/language/full_stacktrace1_test.dart (right):

https://codereview.chromium.org/2687143005/diff/60001/tests/language/full_sta...
tests/language/full_stacktrace1_test.dart:18: print(fullTrace);
leftover from your debugging?

https://codereview.chromium.org/2687143005/diff/60001/tests/language/full_sta...
File tests/language/full_stacktrace2_test.dart (right):

https://codereview.chromium.org/2687143005/diff/60001/tests/language/full_sta...
tests/language/full_stacktrace2_test.dart:18: print(fullTrace);
Ditto.

https://codereview.chromium.org/2687143005/diff/60001/tests/language/full_sta...
tests/language/full_stacktrace2_test.dart:40: print(fullTrace);
Ditto.

https://codereview.chromium.org/2687143005/diff/60001/tests/language/full_sta...
File tests/language/full_stacktrace3_test.dart (right):

https://codereview.chromium.org/2687143005/diff/60001/tests/language/full_sta...
tests/language/full_stacktrace3_test.dart:18: print(fullTrace);
left over from debugging (here and below)?

[rmacnak, 2017-02-13 18:25:34]

https://codereview.chromium.org/2687143005/diff/60001/runtime/tests/vm/dart/o...
File runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart
(right):

https://codereview.chromium.org/2687143005/diff/60001/runtime/tests/vm/dart/o...
runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart:37: }
On 2017/02/11 03:19:00, siva wrote:
> Does it make sense to extend your markers 'A,B,C etc. to the bottom
> part of this file also?

Sure, it makes is possible to find which expect is failing when stack traces
aren't fully function. Done.

https://codereview.chromium.org/2687143005/diff/60001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2687143005/diff/60001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9093: Smi& token_pos = Smi::Handle(zone);
On 2017/02/11 03:19:00, siva wrote:
> this smi could be hoisted above and shared with the smi used in the binary
> search

Done.

https://codereview.chromium.org/2687143005/diff/60001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9124: return min + 1;
On 2017/02/11 03:19:00, siva wrote:
> The + 1 here is because line numbers start from 1 ?

Yes, added comment.

https://codereview.chromium.org/2687143005/diff/60001/tests/language/full_sta...
File tests/language/full_stacktrace1_test.dart (right):

https://codereview.chromium.org/2687143005/diff/60001/tests/language/full_sta...
tests/language/full_stacktrace1_test.dart:18: print(fullTrace);
On 2017/02/11 03:19:00, siva wrote:
> leftover from your debugging?

Leaving it in because the expects below don't produce helpful messages. When the
test passes, all the output is hidden by the test harness.

[rmacnak, 2017-02-13 18:27:41]

Description was changed from

==========
Include metadata in AOT to expand inline frames in stack traces and provide line
numbers.

Also fix stack trace collection to always include invisible frames. It can
happen that a visible function is inlined into an invisible function, and we
don't expand inlined frames until we print a stack trace.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)
==========

to

==========
Include metadata in AOT to expand inline frames in stack traces and provide line
numbers.

Also fix stack trace collection to always include invisible frames. It can
happen that a visible function is inlined into an invisible function, and we
don't expand inlined frames until we print a stack trace.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cfe5e5f075431641642a8e3be2fbd4414eaca1fd
==========

[rmacnak, 2017-02-13 18:27:43]

Committed patchset #5 (id:80001) manually as
cfe5e5f075431641642a8e3be2fbd4414eaca1fd (presubmit successful).