Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: runtime/vm/stack_trace.cc

Issue 2687143005: Include metadata in AOT to expand inline frames in stack traces and provide line numbers. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stack_trace.h ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stack_trace.cc
diff --git a/runtime/vm/stack_trace.cc b/runtime/vm/stack_trace.cc
index 0168e3bc74c92c498fcc73b2a296d60ecfb0e4f1..c746d50104a00f6836daa4ffbaefa83c7f2f1706 100644
--- a/runtime/vm/stack_trace.cc
+++ b/runtime/vm/stack_trace.cc
@@ -10,8 +10,7 @@ namespace dart {
// Count the number of frames that are on the stack.
intptr_t StackTraceUtils::CountFrames(Thread* thread,
int skip_frames,
- const Function& async_function,
- bool count_invisible_frames) {
+ const Function& async_function) {
Zone* zone = thread->zone();
intptr_t frame_count = 0;
StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
@@ -27,9 +26,7 @@ intptr_t StackTraceUtils::CountFrames(Thread* thread,
} else {
code = frame->LookupDartCode();
function = code.function();
- if (function.is_visible() || count_invisible_frames) {
- frame_count++;
- }
+ frame_count++;
if (!async_function_is_null &&
(async_function.raw() == function.parent_function())) {
return frame_count;
@@ -49,8 +46,7 @@ intptr_t StackTraceUtils::CollectFrames(Thread* thread,
const Array& pc_offset_array,
intptr_t array_offset,
intptr_t count,
- int skip_frames,
- bool collect_invisible_frames) {
+ int skip_frames) {
Zone* zone = thread->zone();
StackFrameIterator frames(StackFrameIterator::kDontValidateFrames);
StackFrame* frame = frames.NextFrame();
@@ -66,13 +62,11 @@ intptr_t StackTraceUtils::CollectFrames(Thread* thread,
} else {
code = frame->LookupDartCode();
function = code.function();
- if (function.is_visible() || collect_invisible_frames) {
- offset = Smi::New(frame->pc() - code.PayloadStart());
- code_array.SetAt(array_offset, code);
- pc_offset_array.SetAt(array_offset, offset);
- array_offset++;
- collected_frames_count++;
- }
+ offset = Smi::New(frame->pc() - code.PayloadStart());
+ code_array.SetAt(array_offset, code);
+ pc_offset_array.SetAt(array_offset, offset);
+ array_offset++;
+ collected_frames_count++;
}
}
frame = frames.NextFrame();
« no previous file with comments | « runtime/vm/stack_trace.h ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698