Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: runtime/vm/stack_trace.h

Issue 2687143005: Include metadata in AOT to expand inline frames in stack traces and provide line numbers. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/stack_trace.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stack_trace.h
diff --git a/runtime/vm/stack_trace.h b/runtime/vm/stack_trace.h
index cf116afe7d562b86b90980cdf8d92052c231ff31..5a89221365355a3da62aff852b8ce0d11d77ff3d 100644
--- a/runtime/vm/stack_trace.h
+++ b/runtime/vm/stack_trace.h
@@ -19,24 +19,20 @@ class StackTraceUtils : public AllStatic {
/// Skips over the first |skip_frames|.
/// If |async_function| is not null, stops at the function that has
/// |async_function| as its parent.
- static intptr_t CountFrames(
- Thread* thread,
- int skip_frames,
- const Function& async_function,
- bool count_invisible_frames = FLAG_show_invisible_frames);
+ static intptr_t CountFrames(Thread* thread,
+ int skip_frames,
+ const Function& async_function);
/// Collects |count| frames into |code_array| and |pc_offset_array|.
/// Writing begins at |array_offset|.
/// Skips over the first |skip_frames|.
/// Returns the number of frames collected.
- static intptr_t CollectFrames(
- Thread* thread,
- const Array& code_array,
- const Array& pc_offset_array,
- intptr_t array_offset,
- intptr_t count,
- int skip_frames,
- bool collect_invisible_frames = FLAG_show_invisible_frames);
+ static intptr_t CollectFrames(Thread* thread,
+ const Array& code_array,
+ const Array& pc_offset_array,
+ intptr_t array_offset,
+ intptr_t count,
+ int skip_frames);
/// If |thread| has no async_stack_trace, does nothing.
/// Populates |async_function| with the top function of the async stack
« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/stack_trace.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698