Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: runtime/tests/vm/dart/optimized_stacktrace_test.dart

Issue 2687143005: Include metadata in AOT to expand inline frames in stack traces and provide line numbers. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/dart/optimized_stacktrace_line_test.dart ('k') | runtime/tests/vm/vm.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/tests/vm/dart/optimized_stacktrace_test.dart
diff --git a/runtime/tests/vm/dart/optimized_stacktrace_test.dart b/runtime/tests/vm/dart/optimized_stacktrace_test.dart
deleted file mode 100644
index d002a2e28b0c32c11d9830998c9206ebb6e96297..0000000000000000000000000000000000000000
--- a/runtime/tests/vm/dart/optimized_stacktrace_test.dart
+++ /dev/null
@@ -1,78 +0,0 @@
-// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-// Test correct source positions in stack trace with optimized functions.
-import "package:expect/expect.dart";
-
-// (1) Test normal exception.
-foo(x) => bar(x);
-
-bar(x) {
- if (x == null) throw 42; // throw at position 11:18
- return x + 1;
-}
-
-test1() {
- // First unoptimized.
- try {
- foo(null);
- Expect.fail("Unreachable");
- } catch (e, stacktrace) {
- String s = stacktrace.toString();
- Expect.isFalse(s.contains("-1:-1"));
- Expect.isTrue(s.contains("11:18"));
- }
-
- // Optimized.
- for (var i=0; i<10000; i++) foo(42);
- try {
- foo(null);
- Expect.fail("Unreachable");
- } catch (e, stacktrace) {
- String s = stacktrace.toString();
- Expect.isFalse(s.contains("-1:-1"));
- Expect.isTrue(s.contains("11:18"));
- }
-}
-
-
-// (2) Test checked mode exceptions.
-maximus(x) => moritz(x);
-
-moritz(x) {
- if (x == 333) return 42 ? 0 : 1; // Throws in checked mode.
- if (x == 777) {
- bool b = x; // Throws in checked mode.
- return b;
- }
-
- return x + 1;
-}
-
-test2() {
- for (var i=0; i<100000; i++) maximus(42);
- try {
- maximus(333);
- } catch (e, stacktrace) {
- String s = stacktrace.toString();
- print(s);
- Expect.isTrue(s.contains("maximus"));
- Expect.isTrue(s.contains("moritz"));
- Expect.isFalse(s.contains("-1:-1"));
- }
-
- try {
- maximus(777);
- } catch (e, stacktrace) {
- String s = stacktrace.toString();
- print(s);
- Expect.isTrue(s.contains("maximus"));
- Expect.isTrue(s.contains("moritz"));
- Expect.isFalse(s.contains("-1:-1"));
- }
-}
-
-main() {
- test1();
- test2();
-}
« no previous file with comments | « runtime/tests/vm/dart/optimized_stacktrace_line_test.dart ('k') | runtime/tests/vm/vm.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698