Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2687143003: Fix flaky LayerTreeHostCopyRequestTestDeleteTexture test. (Closed)

Created:
3 years, 10 months ago by danakj
Modified:
3 years, 10 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky LayerTreeHostCopyRequestTestDeleteTexture test. Because CopyOutputRequests make an extra RenderPass, which is backed by a texture, we do a follow-up draw to remove that texture. This raced with the texture counting that the test was doing. So wait for the draw before proceeding. R=vmpstr@chromium.org BUG=675684 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2687143003 Cr-Commit-Position: refs/heads/master@{#449411} Committed: https://chromium.googlesource.com/chromium/src/+/6cd4cd4c30979c6fc520b090f1b64e3bcd1d0868

Patch Set 1 #

Patch Set 2 : flaky-copyrequest: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M cc/resources/video_resource_updater_unittest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M cc/test/test_gles2_interface.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_copyrequest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
danakj
3 years, 10 months ago (2017-02-09 19:23:34 UTC) #3
danakj
The cc/test/ changes just make a single call to TestGLES2Interface result in a single call ...
3 years, 10 months ago (2017-02-09 19:24:24 UTC) #5
vmpstr
lgtm thanks for tracking this down.
3 years, 10 months ago (2017-02-09 19:35:22 UTC) #6
danakj
Had to fix one unit test that was overriding deleteTexture but not deleteTextures
3 years, 10 months ago (2017-02-09 19:43:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687143003/20001
3 years, 10 months ago (2017-02-09 19:44:43 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 21:20:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6cd4cd4c30979c6fc520b090f1b6...

Powered by Google App Engine
This is Rietveld 408576698