cc: Lock access to |buffers_| in TestGpuMemoryBufferManager

cc: Lock access to |buffers_| in TestGpuMemoryBufferManager

The manager is used to create buffers on one thread that may be
destroyed on another thread. When destroyed they call back to the
TestGpuMemoryBufferManager causing a data race.

R=vmpstr@chromium.org
BUG=690588
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2682743007
Cr-Commit-Position: refs/heads/master@{#449426}
Committed: https://chromium.googlesource.com/chromium/src/+/5cd331dec1c51a6040c15c1afb4eb03d77187dbe

[danakj, 2017-02-09 20:04:14]

Description was changed from

==========
cc: Lock access to |buffers_| in TestGpuMemoryBufferManager

The manager is used to create buffers on one thread that may be
destroyed on another thread. When destroyed they call back to the
TestGpuMemoryBufferManager causing a data race.

R=vmpstr@chromium.org
BUG=690588
==========

to

==========
cc: Lock access to |buffers_| in TestGpuMemoryBufferManager

The manager is used to create buffers on one thread that may be
destroyed on another thread. When destroyed they call back to the
TestGpuMemoryBufferManager causing a data race.

R=vmpstr@chromium.org
BUG=690588
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-02-09 20:06:26]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 20:07:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2017-02-09 20:37:16]

lgtm

https://codereview.chromium.org/2682743007/diff/1/cc/test/test_gpu_memory_buf...
File cc/test/test_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/2682743007/diff/1/cc/test/test_gpu_memory_buf...
cc/test/test_gpu_memory_buffer_manager.cc:175: {
nit: don't need braces here, I don't think?

https://codereview.chromium.org/2682743007/diff/1/cc/test/test_gpu_memory_buf...
File cc/test/test_gpu_memory_buffer_manager.h (right):

https://codereview.chromium.org/2682743007/diff/1/cc/test/test_gpu_memory_buf...
cc/test/test_gpu_memory_buffer_manager.h:39: base::Lock buffers_lock_;
nit: Add a small comment about the fact that buffers_ access must be protected
by this lock.

[danakj, 2017-02-09 20:39:43]

https://codereview.chromium.org/2682743007/diff/1/cc/test/test_gpu_memory_buf...
File cc/test/test_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/2682743007/diff/1/cc/test/test_gpu_memory_buf...
cc/test/test_gpu_memory_buffer_manager.cc:175: {
On 2017/02/09 20:37:16, vmpstr wrote:
> nit: don't need braces here, I don't think?

tru

https://codereview.chromium.org/2682743007/diff/1/cc/test/test_gpu_memory_buf...
File cc/test/test_gpu_memory_buffer_manager.h (right):

https://codereview.chromium.org/2682743007/diff/1/cc/test/test_gpu_memory_buf...
cc/test/test_gpu_memory_buffer_manager.h:39: base::Lock buffers_lock_;
On 2017/02/09 20:37:16, vmpstr wrote:
> nit: Add a small comment about the fact that buffers_ access must be protected
> by this lock.

Done.

[danakj, 2017-02-09 20:39:56]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-02-09 20:39:57]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2682743007/#ps20001
(title: "lockbuffers: .")

[commit-bot: I haz the power, 2017-02-09 20:40:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 21:51:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486672796659860,
"parent_rev": "5d27021cb89ffb8f0e1e1eb47f34dc13ee6d3ca3", "commit_rev":
"5cd331dec1c51a6040c15c1afb4eb03d77187dbe"}

[commit-bot: I haz the power, 2017-02-09 21:51:43]

Description was changed from

==========
cc: Lock access to |buffers_| in TestGpuMemoryBufferManager

The manager is used to create buffers on one thread that may be
destroyed on another thread. When destroyed they call back to the
TestGpuMemoryBufferManager causing a data race.

R=vmpstr@chromium.org
BUG=690588
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Lock access to |buffers_| in TestGpuMemoryBufferManager

The manager is used to create buffers on one thread that may be
destroyed on another thread. When destroyed they call back to the
TestGpuMemoryBufferManager causing a data race.

R=vmpstr@chromium.org
BUG=690588
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2682743007
Cr-Commit-Position: refs/heads/master@{#449426}
Committed:
https://chromium.googlesource.com/chromium/src/+/5cd331dec1c51a6040c15c1afb4e...
==========

[commit-bot: I haz the power, 2017-02-09 21:51:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5cd331dec1c51a6040c15c1afb4e...