Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3734)

Unified Diff: cc/trees/layer_tree_host_unittest_copyrequest.cc

Issue 2687143003: Fix flaky LayerTreeHostCopyRequestTestDeleteTexture test. (Closed)
Patch Set: flaky-copyrequest: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/test_web_graphics_context_3d.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest_copyrequest.cc
diff --git a/cc/trees/layer_tree_host_unittest_copyrequest.cc b/cc/trees/layer_tree_host_unittest_copyrequest.cc
index cf8b1cd119a45e96a8dabff23c7679b3542212bf..23ec0736843b2f7ca9566e70c0f0fe45004065fa 100644
--- a/cc/trees/layer_tree_host_unittest_copyrequest.cc
+++ b/cc/trees/layer_tree_host_unittest_copyrequest.cc
@@ -814,6 +814,11 @@ class LayerTreeHostCopyRequestTestDeleteTexture
base::Unretained(this)));
break;
case 1:
+ // Copy requests cause a followup commit and draw without the separate
+ // RenderPass required. This changes the number of active textures. So
+ // wait for that draw before counting textures and proceeding.
+ break;
+ case 2:
// We did a readback, so there will be a readback texture around now.
num_textures_after_readback_ =
display_context_provider_->TestContext3d()->NumTextures();
« no previous file with comments | « cc/test/test_web_graphics_context_3d.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698