Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2686733003: [Payments] Move Android strings to components/payments_strings.grdp (Closed)

Created:
3 years, 10 months ago by Mathieu
Modified:
3 years, 10 months ago
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Move Android strings to components/payments_strings.grdp The plan is to use the strings on desktop in a next patch. BUG=689768 TEST=builds Review-Url: https://codereview.chromium.org/2686733003 Cr-Commit-Position: refs/heads/master@{#448964} Committed: https://chromium.googlesource.com/chromium/src/+/9b6acec18fdd1e35921ca18501b5dfd002e1ce4c

Patch Set 1 #

Patch Set 2 : Initial #

Patch Set 3 : OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -192 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 chunks +1 line, -192 lines 0 comments Download
M components/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download
A components/payments_strings.grdp View 1 chunk +194 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Mathieu
Hi, PTAL
3 years, 10 months ago (2017-02-08 01:49:23 UTC) #4
jochen (gone - plz use gerrit)
why not add owners for the new file?
3 years, 10 months ago (2017-02-08 09:01:15 UTC) #8
Mathieu
On 2017/02/08 09:01:15, jochen wrote: > why not add owners for the new file? Good ...
3 years, 10 months ago (2017-02-08 11:17:36 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-08 11:38:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686733003/40001
3 years, 10 months ago (2017-02-08 11:40:36 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 12:25:47 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9b6acec18fdd1e35921ca18501b5...

Powered by Google App Engine
This is Rietveld 408576698