Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2685733002: S390: Use macro to declare rxy format assember function (Closed)

Created:
3 years, 10 months ago by Sampson
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use S390X_RXY_A_OPCODE_LIST macro to declare rxy format assembler function BUG= R=jyan@ca.ibm.com, joransiu@ca.ibm.com, bjaideep@ca.ibm.com Review-Url: https://codereview.chromium.org/2685733002 Cr-Commit-Position: refs/heads/master@{#43042} Committed: https://chromium.googlesource.com/v8/v8/+/bcfcea1c76e880d3a9db7c4998533354a9e9c2da

Patch Set 1 #

Patch Set 2 : Use static cast for casting integer to Condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -456 lines) Patch
M src/s390/assembler-s390.h View 8 chunks +33 lines, -87 lines 0 comments Download
M src/s390/assembler-s390.cc View 20 chunks +2 lines, -364 lines 0 comments Download
M src/s390/constants-s390.h View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Sampson
Please take a look.
3 years, 10 months ago (2017-02-07 21:01:08 UTC) #3
john.yan
lgtm
3 years, 10 months ago (2017-02-08 04:10:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2685733002/20001
3 years, 10 months ago (2017-02-08 15:49:04 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 16:10:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/bcfcea1c76e880d3a9db7c4998533354a9e...

Powered by Google App Engine
This is Rietveld 408576698