Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2266)

Unified Diff: content/browser/webrtc/webrtc_getusermedia_browsertest.cc

Issue 2684233005: Revert of Use spec-compliant algorithm to select video devices in getUserMedia. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/media_stream_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/webrtc/webrtc_getusermedia_browsertest.cc
diff --git a/content/browser/webrtc/webrtc_getusermedia_browsertest.cc b/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
index 3dfb8284870ed9c1d6c029547b0cf1b984377b66..64401768a6d98eb5792f0f7276937b323b0a8ef0 100644
--- a/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
+++ b/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
@@ -414,8 +414,6 @@
GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
// Test with invalid mandatory audio sourceID.
- // TODO(guidou): Update error string when spec-compliant constraint resolution
- // for audio is implemented. See http://crbug.com/657733.
NavigateToURL(shell(), url);
EXPECT_EQ("DevicesNotFoundError", ExecuteJavascriptAndReturnResult(
GenerateGetUserMediaWithMandatorySourceID(
@@ -424,15 +422,13 @@
video_ids[0])));
// Test with invalid mandatory video sourceID.
- EXPECT_EQ("ConstraintNotSatisfiedError",
- ExecuteJavascriptAndReturnResult(
- GenerateGetUserMediaWithMandatorySourceID(
- kGetUserMediaAndExpectFailure, audio_ids[0],
- "something invalid")));
+ EXPECT_EQ("DevicesNotFoundError", ExecuteJavascriptAndReturnResult(
+ GenerateGetUserMediaWithMandatorySourceID(
+ kGetUserMediaAndExpectFailure,
+ audio_ids[0],
+ "something invalid")));
// Test with empty mandatory audio sourceID.
- // TODO(guidou): Update error string when spec-compliant constraint resolution
- // for audio is implemented. See http://crbug.com/657733.
EXPECT_EQ("DevicesNotFoundError", ExecuteJavascriptAndReturnResult(
GenerateGetUserMediaWithMandatorySourceID(
kGetUserMediaAndExpectFailure,
« no previous file with comments | « no previous file | content/renderer/media/media_stream_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698