Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2683113006: Revert of Simplify the registration of the Chrome Recovery component. (Closed)

Created:
3 years, 10 months ago by Bret
Modified:
3 years, 10 months ago
Reviewers:
waffles, Sorin Jianu, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify the registration of the Chrome Recovery component. (patchset #2 id:20001 of https://codereview.chromium.org/2686863004/ ) Reason for revert: Causing a build failure on Linux x64. Example failure: https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/16208 Original issue's description: > Simplify the registration of the Chrome Recovery component. > > BUG=690574 > > Review-Url: https://codereview.chromium.org/2686863004 > Cr-Commit-Position: refs/heads/master@{#449439} > Committed: https://chromium.googlesource.com/chromium/src/+/ff39aeb77a4a4e1679cfc5feed58e40e98f472ee TBR=sky@chromium.org,waffles@chromium.org,sorin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=690574 Review-Url: https://codereview.chromium.org/2683113006 Cr-Commit-Position: refs/heads/master@{#449500} Committed: https://chromium.googlesource.com/chromium/src/+/18e2d51bf90c1c88b1f8c5ed0cde3147ba7dda28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Bret
Created Revert of Simplify the registration of the Chrome Recovery component.
3 years, 10 months ago (2017-02-10 01:15:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683113006/1
3 years, 10 months ago (2017-02-10 01:16:31 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 01:18:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18e2d51bf90c1c88b1f8c5ed0cde...

Powered by Google App Engine
This is Rietveld 408576698