Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2686863004:
Simplify the registration of the Chrome Recovery component. (Closed)
|
Created:
3 years, 10 months ago by Sorin Jianu Modified:
3 years, 10 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSimplify the registration of the Chrome Recovery component.
BUG=690574
Review-Url: https://codereview.chromium.org/2686863004
Cr-Original-Commit-Position: refs/heads/master@{#449439}
Committed: https://chromium.googlesource.com/chromium/src/+/ff39aeb77a4a4e1679cfc5feed58e40e98f472ee
Review-Url: https://codereview.chromium.org/2686863004
Cr-Commit-Position: refs/heads/master@{#450057}
Committed: https://chromium.googlesource.com/chromium/src/+/c84a7d30ef832b6e29904ccba7213f628d206654
Patch Set 1 #Patch Set 2 : rebase the dependent patch set #Patch Set 3 : fix Google build break #Patch Set 4 : rebase #Patch Set 5 : fix broken chromium build #
Messages
Total messages: 40 (30 generated)
The CQ bit was checked by sorin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sorin@chromium.org
The CQ bit was unchecked by sorin@chromium.org
sorin@chromium.org changed reviewers: + waffles@chromium.org
PTAL, thank you!
lgtm, thanks!
sorin@chromium.org changed reviewers: + sky@chromium.org, waffle.iron@gmail.com - waffles@chromium.org
Scott, I need an owner's approval for the changes in chrome_browser_main.cc Thank you!
LGTM
The CQ bit was checked by sorin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org Link to the patchset: https://codereview.chromium.org/2686863004/#ps20001 (title: "rebase the dependent patch set")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486676615876570,
"parent_rev": "ffefd4173f178d76449fc51f5dc22bfd7e120e03", "commit_rev":
"ff39aeb77a4a4e1679cfc5feed58e40e98f472ee"}
Message was sent while issue was closed.
Description was changed from ========== Simplify the registration of the Chrome Recovery component. BUG=690574 ========== to ========== Simplify the registration of the Chrome Recovery component. BUG=690574 Review-Url: https://codereview.chromium.org/2686863004 Cr-Commit-Position: refs/heads/master@{#449439} Committed: https://chromium.googlesource.com/chromium/src/+/ff39aeb77a4a4e1679cfc5feed58... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ff39aeb77a4a4e1679cfc5feed58...
Message was sent while issue was closed.
Description was changed from ========== Simplify the registration of the Chrome Recovery component. BUG=690574 Review-Url: https://codereview.chromium.org/2686863004 Cr-Commit-Position: refs/heads/master@{#449439} Committed: https://chromium.googlesource.com/chromium/src/+/ff39aeb77a4a4e1679cfc5feed58... ========== to ========== Simplify the registration of the Chrome Recovery component. BUG=690574 Review-Url: https://codereview.chromium.org/2686863004 Cr-Commit-Position: refs/heads/master@{#449439} Committed: https://chromium.googlesource.com/chromium/src/+/ff39aeb77a4a4e1679cfc5feed58... ==========
Message was sent while issue was closed.
sorin@chromium.org changed reviewers: + waffles@chromium.org - waffle.iron@gmail.com
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2683113006/ by bsep@chromium.org. The reason for reverting is: Causing a build failure on Linux x64. Example failure: https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chro....
The CQ bit was checked by sorin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by sorin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by sorin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sorin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org, waffles@chromium.org Link to the patchset: https://codereview.chromium.org/2686863004/#ps80001 (title: "fix broken chromium build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487014732310430,
"parent_rev": "b7402e0e149bc2e59d44f5378b86b26d9d35565e", "commit_rev":
"c84a7d30ef832b6e29904ccba7213f628d206654"}
Message was sent while issue was closed.
Description was changed from ========== Simplify the registration of the Chrome Recovery component. BUG=690574 Review-Url: https://codereview.chromium.org/2686863004 Cr-Commit-Position: refs/heads/master@{#449439} Committed: https://chromium.googlesource.com/chromium/src/+/ff39aeb77a4a4e1679cfc5feed58... ========== to ========== Simplify the registration of the Chrome Recovery component. BUG=690574 Review-Url: https://codereview.chromium.org/2686863004 Cr-Original-Commit-Position: refs/heads/master@{#449439} Committed: https://chromium.googlesource.com/chromium/src/+/ff39aeb77a4a4e1679cfc5feed58... Review-Url: https://codereview.chromium.org/2686863004 Cr-Commit-Position: refs/heads/master@{#450057} Committed: https://chromium.googlesource.com/chromium/src/+/c84a7d30ef832b6e29904ccba721... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/c84a7d30ef832b6e29904ccba721... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
