Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Side by Side Diff: chrome/browser/chrome_browser_main.cc

Issue 2683113006: Revert of Simplify the registration of the Chrome Recovery component. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/component_updater/recovery_component_installer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main.h" 5 #include "chrome/browser/chrome_browser_main.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <set> 10 #include <set>
(...skipping 450 matching lines...) Expand 10 before | Expand all | Expand 10 after
461 } 461 }
462 462
463 #if defined(OS_MACOSX) 463 #if defined(OS_MACOSX)
464 OSStatus KeychainCallback(SecKeychainEvent keychain_event, 464 OSStatus KeychainCallback(SecKeychainEvent keychain_event,
465 SecKeychainCallbackInfo* info, void* context) { 465 SecKeychainCallbackInfo* info, void* context) {
466 return noErr; 466 return noErr;
467 } 467 }
468 #endif // defined(OS_MACOSX) 468 #endif // defined(OS_MACOSX)
469 469
470 void RegisterComponentsForUpdate() { 470 void RegisterComponentsForUpdate() {
471 const auto cus = g_browser_process->component_updater(); 471 component_updater::ComponentUpdateService* cus =
472 g_browser_process->component_updater();
472 473
474 // Registration can be before or after cus->Start() so it is ok to post
475 // a task to the UI thread to do registration once you done the necessary
476 // file IO to know you existing component version.
477 #if !defined(OS_ANDROID)
478 #if !defined(OS_CHROMEOS)
473 if (base::FeatureList::IsEnabled(features::kImprovedRecoveryComponent)) 479 if (base::FeatureList::IsEnabled(features::kImprovedRecoveryComponent))
474 RegisterRecoveryImprovedComponent(cus, g_browser_process->local_state()); 480 RegisterRecoveryImprovedComponent(cus, g_browser_process->local_state());
475 else 481 else
476 RegisterRecoveryComponent(cus, g_browser_process->local_state()); 482 RegisterRecoveryComponent(cus, g_browser_process->local_state());
477 483 #endif // !defined(OS_CHROMEOS)
478 #if !defined(OS_ANDROID)
479 RegisterPepperFlashComponent(cus); 484 RegisterPepperFlashComponent(cus);
480 #if !defined(OS_CHROMEOS) 485 #if !defined(OS_CHROMEOS)
481 RegisterSwiftShaderComponent(cus); 486 RegisterSwiftShaderComponent(cus);
482 RegisterWidevineCdmComponent(cus); 487 RegisterWidevineCdmComponent(cus);
483 #endif // !defined(OS_CHROMEOS) 488 #endif // !defined(OS_CHROMEOS)
484 #endif // !defined(OS_ANDROID) 489 #endif // !defined(OS_ANDROID)
485 490
486 #if !defined(DISABLE_NACL) && !defined(OS_ANDROID) 491 #if !defined(DISABLE_NACL) && !defined(OS_ANDROID)
487 #if defined(OS_CHROMEOS) 492 #if defined(OS_CHROMEOS)
488 // PNaCl on Chrome OS is on rootfs and there is no need to download it. But 493 // PNaCl on Chrome OS is on rootfs and there is no need to download it. But
(...skipping 1620 matching lines...) Expand 10 before | Expand all | Expand 10 after
2109 chromeos::CrosSettings::Shutdown(); 2114 chromeos::CrosSettings::Shutdown();
2110 #endif // defined(OS_CHROMEOS) 2115 #endif // defined(OS_CHROMEOS)
2111 #endif // defined(OS_ANDROID) 2116 #endif // defined(OS_ANDROID)
2112 } 2117 }
2113 2118
2114 // Public members: 2119 // Public members:
2115 2120
2116 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) { 2121 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
2117 chrome_extra_parts_.push_back(parts); 2122 chrome_extra_parts_.push_back(parts);
2118 } 2123 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/component_updater/recovery_component_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698