Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2683103002: Rewrite presubmit scripts to use new EnsureCQIncludeTrybotsAreAdded. (Closed)

Created:
3 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 10 months ago
CC:
blink-reviews, caitkp+watch_chromium.org, cbentzel+watch_chromium.org, cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, fukino+watch_chromium.org, haraken, jam, mtomasz+watch_chromium.org, net-reviews_chromium.org, oka+watch_chromium.org, oshima+watch_chromium.org, pennymac+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, rginda+watch_chromium.org, tandrii(chromium), wfh+watch_chromium.org, yamaguchi+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite presubmit scripts to use new EnsureCQIncludeTrybotsAreAdded. BUG=688765 TBR=enne@chromium.org,grt@chromium.org,robertshield@chromium.org,kapishnikov@chromium.org,zmo@chromium.org,vmiura@chromium.org,dalecurtis@chromium.org,jschuh@chromium.org,hirono@chromium.org,dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2683103002 Cr-Commit-Position: refs/heads/master@{#451034} Committed: https://chromium.googlesource.com/chromium/src/+/4384263c0f3708fa0a0f24ceba40ee595ef08739

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Not for commit: Test composability of presubmit scripts. #

Patch Set 4 : Undid accidental changes. #

Patch Set 5 : Worked around unrelated presubmit failure under cronet. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -282 lines) Patch
M cc/PRESUBMIT.py View 1 1 chunk +6 lines, -22 lines 0 comments Download
M chrome/browser/win/PRESUBMIT.py View 1 chunk +6 lines, -20 lines 0 comments Download
M chrome_elf/PRESUBMIT.py View 1 chunk +6 lines, -22 lines 0 comments Download
M components/cronet/PRESUBMIT.py View 1 2 chunks +6 lines, -21 lines 0 comments Download
M components/cronet/android/test/javaperftests/run.py View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/gpu/PRESUBMIT.py View 2 chunks +14 lines, -27 lines 0 comments Download
M gpu/PRESUBMIT.py View 1 chunk +13 lines, -26 lines 0 comments Download
M media/audio/PRESUBMIT.py View 2 chunks +8 lines, -24 lines 0 comments Download
M media/gpu/PRESUBMIT.py View 2 chunks +8 lines, -24 lines 0 comments Download
M sandbox/win/PRESUBMIT.py View 1 chunk +6 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/PRESUBMIT.py View 1 chunk +12 lines, -29 lines 0 comments Download
M ui/file_manager/PRESUBMIT.py View 1 chunk +6 lines, -24 lines 0 comments Download
M ui/webui/resources/PRESUBMIT.py View 1 chunk +6 lines, -21 lines 0 comments Download

Messages

Total messages: 43 (25 generated)
Ken Russell (switch to Gerrit)
Reviewers: FYI only. This CL refactors your PRESUBMIT scripts to use a new primitive in ...
3 years, 10 months ago (2017-02-15 21:16:12 UTC) #13
tandrii(chromium)
lgtm
3 years, 10 months ago (2017-02-15 21:17:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683103002/60001
3 years, 10 months ago (2017-02-15 21:18:08 UTC) #17
robertshield
chrome_elf lgtm
3 years, 10 months ago (2017-02-15 21:25:50 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/2201)
3 years, 10 months ago (2017-02-15 22:10:05 UTC) #20
jschuh
sandbox lgtm
3 years, 10 months ago (2017-02-15 22:37:58 UTC) #21
Dan Beam
yay! \o/ lgtm
3 years, 10 months ago (2017-02-15 22:39:18 UTC) #22
Ken Russell (switch to Gerrit)
The trybot failure above is unrelated, though I did clear up a presubmit failure under ...
3 years, 10 months ago (2017-02-15 22:47:31 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683103002/80001
3 years, 10 months ago (2017-02-15 22:48:14 UTC) #26
DaleCurtis
Fancy, media/ lgtm
3 years, 10 months ago (2017-02-15 22:50:19 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) closure_compilation on ...
3 years, 10 months ago (2017-02-16 00:50:33 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683103002/80001
3 years, 10 months ago (2017-02-16 00:58:59 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/322898)
3 years, 10 months ago (2017-02-16 02:20:28 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683103002/80001
3 years, 10 months ago (2017-02-16 02:36:44 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-16 03:01:45 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683103002/80001
3 years, 10 months ago (2017-02-16 18:51:37 UTC) #39
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/4384263c0f3708fa0a0f24ceba40ee595ef08739
3 years, 10 months ago (2017-02-16 19:07:42 UTC) #42
grt (UTC plus 2)
3 years, 10 months ago (2017-02-20 09:11:36 UTC) #43
Message was sent while issue was closed. 
chrome/browser/win LGTM

Powered by Google App Engine
This is Rietveld 408576698