Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: ui/file_manager/PRESUBMIT.py

Issue 2683103002: Rewrite presubmit scripts to use new EnsureCQIncludeTrybotsAreAdded. (Closed)
Patch Set: Worked around unrelated presubmit failure under cronet. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/PRESUBMIT.py ('k') | ui/webui/resources/PRESUBMIT.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/PRESUBMIT.py
diff --git a/ui/file_manager/PRESUBMIT.py b/ui/file_manager/PRESUBMIT.py
index 1a7cbb3932116d1aa95ab1e852a4a3d7a0e581a5..c6783c42d7081608563af275d993460d8dabb532 100644
--- a/ui/file_manager/PRESUBMIT.py
+++ b/ui/file_manager/PRESUBMIT.py
@@ -2,28 +2,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import re
-
-
def PostUploadHook(cl, change, output_api):
- rietveld_obj = cl.RpcServer()
- description = rietveld_obj.get_description(cl.issue)
-
- existing_bots = (change.CQ_INCLUDE_TRYBOTS or '').split(';')
- clean_bots = set(filter(None, map(lambda s: s.strip(), existing_bots)))
- new_bots = clean_bots | set(
- ['master.tryserver.chromium.linux:closure_compilation'])
- new_tag = 'CQ_INCLUDE_TRYBOTS=%s' % ';'.join(new_bots)
-
- if clean_bots:
- tag_reg = '^CQ_INCLUDE_TRYBOTS=.*$'
- new_description = re.sub(tag_reg, new_tag, description, flags=re.M | re.I)
- else:
- new_description = description + '\n' + new_tag
-
- if new_description == description:
- return []
-
- rietveld_obj.update_description(cl.issue, new_description)
- return [output_api.PresubmitNotifyResult(
- 'Automatically added optional Closure bots to run on CQ.')]
+ return output_api.EnsureCQIncludeTrybotsAreAdded(
+ cl,
+ [
+ 'master.tryserver.chromium.linux:closure_compilation',
+ ],
+ 'Automatically added optional Closure bots to run on CQ.')
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/PRESUBMIT.py ('k') | ui/webui/resources/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698