Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: components/cronet/android/test/javaperftests/run.py

Issue 2683103002: Rewrite presubmit scripts to use new EnsureCQIncludeTrybotsAreAdded. (Closed)
Patch Set: Worked around unrelated presubmit failure under cronet. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/PRESUBMIT.py ('k') | content/test/gpu/PRESUBMIT.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javaperftests/run.py
diff --git a/components/cronet/android/test/javaperftests/run.py b/components/cronet/android/test/javaperftests/run.py
index d854924569c559f72f67f9722e671afdad0a6779..087c2b12a9288cd857bfb0c782e516b592f33f69 100755
--- a/components/cronet/android/test/javaperftests/run.py
+++ b/components/cronet/android/test/javaperftests/run.py
@@ -219,6 +219,9 @@ class QuicServer(object):
self._quic_server_doc_root = quic_server_doc_root
def StartupQuicServer(self, device):
+ # Chromium's presubmit checks aren't smart enough to understand
+ # the redirect done in build/android/pylib/pexpect.py.
+ # pylint: disable=no-member
self._process = pexpect.spawn(QUIC_SERVER,
['--quic_in_memory_cache_dir=%s' %
self._quic_server_doc_root,
« no previous file with comments | « components/cronet/PRESUBMIT.py ('k') | content/test/gpu/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698