Make delegated permissions use mojo generated -permissions.

Make delegated permissions use mojo generated -permissions.

Remove the WebPermissionType as the only feature which used it
was delegated permissions.

BUG=614608
Review-Url: https://codereview.chromium.org/2682953002
Cr-Commit-Position: refs/heads/master@{#449573}
Committed: https://chromium.googlesource.com/chromium/src/+/e777c2aebf305f494ca8186328b03532a78f35d8

[riju_, 2017-02-08 12:35:21]

Description was changed from

==========
Make delegated permissions use mojo generated -permissions.

Remove the WebPermissionType as the only feature which used it
was delegated permissions.

BUG=none
==========

to

==========
Make delegated permissions use mojo generated -permissions.

Remove the WebPermissionType as the only feature which used it
was delegated permissions.

BUG=614608
==========

[riju_, 2017-02-08 12:35:21]

rijubrata.bhaumik@intel.com changed reviewers:
+ mlamouri@chromium.org, raymes@chromium.org

[riju_, 2017-02-08 12:37:52]

some context: https://codereview.chromium.org/2676973003/

Also suggested by mounir : https://codereview.chromium.org/2676973003/#msg9

[riju_, 2017-02-08 15:57:41]

The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 15:58:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 17:37:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 17:37:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[raymes, 2017-02-08 23:07:48]

This lgtm but I'm actually about to delete the permission delegation code since
it has been superseded by Feature Policy. We might just want to do it in one go.

Either way though, this seems ok as an incremental change.

https://codereview.chromium.org/2682953002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLIFrameElementPermissions.cpp
(right):

https://codereview.chromium.org/2682953002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLIFrameElementPermissions.cpp:8: #include
"public/platform/modules/permissions/permission.mojom-blink.h"
nit: This is in the header so it's not needed here

[riju_, 2017-02-09 07:53:44]

rijubrata.bhaumik@intel.com changed reviewers:
+ haraken@chromium.org, kinuko@chromium.org

[riju_, 2017-02-09 07:53:45]

Thanks @raymes for the info.

mounir: modules/permissions
kinuko: content/common
haraken: third_party/WebKit

https://codereview.chromium.org/2682953002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLIFrameElementPermissions.cpp
(right):

https://codereview.chromium.org/2682953002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLIFrameElementPermissions.cpp:8: #include
"public/platform/modules/permissions/permission.mojom-blink.h"
On 2017/02/08 23:07:48, raymes wrote:
> nit: This is in the header so it's not needed here

Done.

[riju_, 2017-02-09 07:55:12]

Security_Owners: content/common/frame_messages.h

[haraken, 2017-02-09 07:55:31]

WebKit LGTM

[riju_, 2017-02-09 08:18:54]

rijubrata.bhaumik@intel.com changed reviewers:
+ dcheng@chromium.org

[riju_, 2017-02-09 08:18:55]

dcheng@ : content/common/frame_messages.h

[kinuko, 2017-02-09 08:36:03]

lgtm

[dcheng, 2017-02-09 22:48:20]

rs lgtm

[riju_, 2017-02-10 08:02:39]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[riju_, 2017-02-10 08:02:39]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2682953002/#ps20001
(title: "fix nit")

[commit-bot: I haz the power, 2017-02-10 08:03:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 10:01:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486713759070580,
"parent_rev": "6ac19e1710b6bdf828bc721d56c1f7ba8e48ff73", "commit_rev":
"e777c2aebf305f494ca8186328b03532a78f35d8"}

[commit-bot: I haz the power, 2017-02-10 10:01:47]

Description was changed from

==========
Make delegated permissions use mojo generated -permissions.

Remove the WebPermissionType as the only feature which used it
was delegated permissions.

BUG=614608
==========

to

==========
Make delegated permissions use mojo generated -permissions.

Remove the WebPermissionType as the only feature which used it
was delegated permissions.

BUG=614608

Review-Url: https://codereview.chromium.org/2682953002
Cr-Commit-Position: refs/heads/master@{#449573}
Committed:
https://chromium.googlesource.com/chromium/src/+/e777c2aebf305f494ca8186328b0...
==========

[commit-bot: I haz the power, 2017-02-10 10:01:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e777c2aebf305f494ca8186328b0...