Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: third_party/WebKit/Source/core/html/HTMLIFrameElementPermissionsTest.cpp

Issue 2682953002: Make delegated permissions use mojo generated -permissions. (Closed)
Patch Set: fix nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLIFrameElementPermissionsTest.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLIFrameElementPermissionsTest.cpp b/third_party/WebKit/Source/core/html/HTMLIFrameElementPermissionsTest.cpp
index 9917bb0198751d92f574ee6056f83b58620ea666..920b7416b47f4b748db6e03137a2a87c6746bbbe 100644
--- a/third_party/WebKit/Source/core/html/HTMLIFrameElementPermissionsTest.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLIFrameElementPermissionsTest.cpp
@@ -4,7 +4,7 @@
#include "core/html/HTMLIFrameElementPermissions.h"
-#include "public/platform/modules/permissions/WebPermissionType.h"
+#include "public/platform/modules/permissions/permission.mojom-blink.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace blink {
@@ -12,13 +12,13 @@ namespace blink {
TEST(HTMLIFrameElementPermissionsTest, ParseDelegatedPermissionsValid) {
HTMLIFrameElementPermissions* permissions =
HTMLIFrameElementPermissions::create(nullptr);
- Vector<WebPermissionType> result;
+ Vector<mojom::blink::PermissionName> result;
String errorMessage;
permissions->setValue("midi");
result = permissions->parseDelegatedPermissions(errorMessage);
EXPECT_EQ(1u, result.size());
- EXPECT_EQ(WebPermissionTypeMidiSysEx, result[0]);
+ EXPECT_EQ(mojom::blink::PermissionName::MIDI, result[0]);
permissions->setValue("");
result = permissions->parseDelegatedPermissions(errorMessage);
@@ -27,14 +27,14 @@ TEST(HTMLIFrameElementPermissionsTest, ParseDelegatedPermissionsValid) {
permissions->setValue("geolocation midi");
result = permissions->parseDelegatedPermissions(errorMessage);
EXPECT_EQ(2u, result.size());
- EXPECT_EQ(WebPermissionTypeGeolocation, result[0]);
- EXPECT_EQ(WebPermissionTypeMidiSysEx, result[1]);
+ EXPECT_EQ(mojom::blink::PermissionName::GEOLOCATION, result[0]);
+ EXPECT_EQ(mojom::blink::PermissionName::MIDI, result[1]);
}
TEST(HTMLIFrameElementPermissionsTest, ParseDelegatedPermissionsInvalid) {
HTMLIFrameElementPermissions* permissions =
HTMLIFrameElementPermissions::create(nullptr);
- Vector<WebPermissionType> result;
+ Vector<mojom::blink::PermissionName> result;
String errorMessage;
permissions->setValue("midis");
@@ -51,7 +51,7 @@ TEST(HTMLIFrameElementPermissionsTest, ParseDelegatedPermissionsInvalid) {
permissions->setValue("geolocation midis");
result = permissions->parseDelegatedPermissions(errorMessage);
EXPECT_EQ(1u, result.size());
- EXPECT_EQ(WebPermissionTypeGeolocation, result[0]);
+ EXPECT_EQ(mojom::blink::PermissionName::GEOLOCATION, result[0]);
EXPECT_EQ("'midis' is an invalid permissions flag.", errorMessage);
}

Powered by Google App Engine
This is Rietveld 408576698