Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLIFrameElementPermissionsTest.cpp

Issue 2682953002: Make delegated permissions use mojo generated -permissions. (Closed)
Patch Set: fix nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/html/HTMLIFrameElementPermissions.h" 5 #include "core/html/HTMLIFrameElementPermissions.h"
6 6
7 #include "public/platform/modules/permissions/WebPermissionType.h" 7 #include "public/platform/modules/permissions/permission.mojom-blink.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 TEST(HTMLIFrameElementPermissionsTest, ParseDelegatedPermissionsValid) { 12 TEST(HTMLIFrameElementPermissionsTest, ParseDelegatedPermissionsValid) {
13 HTMLIFrameElementPermissions* permissions = 13 HTMLIFrameElementPermissions* permissions =
14 HTMLIFrameElementPermissions::create(nullptr); 14 HTMLIFrameElementPermissions::create(nullptr);
15 Vector<WebPermissionType> result; 15 Vector<mojom::blink::PermissionName> result;
16 String errorMessage; 16 String errorMessage;
17 17
18 permissions->setValue("midi"); 18 permissions->setValue("midi");
19 result = permissions->parseDelegatedPermissions(errorMessage); 19 result = permissions->parseDelegatedPermissions(errorMessage);
20 EXPECT_EQ(1u, result.size()); 20 EXPECT_EQ(1u, result.size());
21 EXPECT_EQ(WebPermissionTypeMidiSysEx, result[0]); 21 EXPECT_EQ(mojom::blink::PermissionName::MIDI, result[0]);
22 22
23 permissions->setValue(""); 23 permissions->setValue("");
24 result = permissions->parseDelegatedPermissions(errorMessage); 24 result = permissions->parseDelegatedPermissions(errorMessage);
25 EXPECT_EQ(0u, result.size()); 25 EXPECT_EQ(0u, result.size());
26 26
27 permissions->setValue("geolocation midi"); 27 permissions->setValue("geolocation midi");
28 result = permissions->parseDelegatedPermissions(errorMessage); 28 result = permissions->parseDelegatedPermissions(errorMessage);
29 EXPECT_EQ(2u, result.size()); 29 EXPECT_EQ(2u, result.size());
30 EXPECT_EQ(WebPermissionTypeGeolocation, result[0]); 30 EXPECT_EQ(mojom::blink::PermissionName::GEOLOCATION, result[0]);
31 EXPECT_EQ(WebPermissionTypeMidiSysEx, result[1]); 31 EXPECT_EQ(mojom::blink::PermissionName::MIDI, result[1]);
32 } 32 }
33 33
34 TEST(HTMLIFrameElementPermissionsTest, ParseDelegatedPermissionsInvalid) { 34 TEST(HTMLIFrameElementPermissionsTest, ParseDelegatedPermissionsInvalid) {
35 HTMLIFrameElementPermissions* permissions = 35 HTMLIFrameElementPermissions* permissions =
36 HTMLIFrameElementPermissions::create(nullptr); 36 HTMLIFrameElementPermissions::create(nullptr);
37 Vector<WebPermissionType> result; 37 Vector<mojom::blink::PermissionName> result;
38 String errorMessage; 38 String errorMessage;
39 39
40 permissions->setValue("midis"); 40 permissions->setValue("midis");
41 result = permissions->parseDelegatedPermissions(errorMessage); 41 result = permissions->parseDelegatedPermissions(errorMessage);
42 EXPECT_EQ(0u, result.size()); 42 EXPECT_EQ(0u, result.size());
43 EXPECT_EQ("'midis' is an invalid permissions flag.", errorMessage); 43 EXPECT_EQ("'midis' is an invalid permissions flag.", errorMessage);
44 44
45 permissions->setValue("geolocations midis"); 45 permissions->setValue("geolocations midis");
46 result = permissions->parseDelegatedPermissions(errorMessage); 46 result = permissions->parseDelegatedPermissions(errorMessage);
47 EXPECT_EQ(0u, result.size()); 47 EXPECT_EQ(0u, result.size());
48 EXPECT_EQ("'geolocations', 'midis' are invalid permissions flags.", 48 EXPECT_EQ("'geolocations', 'midis' are invalid permissions flags.",
49 errorMessage); 49 errorMessage);
50 50
51 permissions->setValue("geolocation midis"); 51 permissions->setValue("geolocation midis");
52 result = permissions->parseDelegatedPermissions(errorMessage); 52 result = permissions->parseDelegatedPermissions(errorMessage);
53 EXPECT_EQ(1u, result.size()); 53 EXPECT_EQ(1u, result.size());
54 EXPECT_EQ(WebPermissionTypeGeolocation, result[0]); 54 EXPECT_EQ(mojom::blink::PermissionName::GEOLOCATION, result[0]);
55 EXPECT_EQ("'midis' is an invalid permissions flag.", errorMessage); 55 EXPECT_EQ("'midis' is an invalid permissions flag.", errorMessage);
56 } 56 }
57 57
58 } // namespace blink 58 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698