Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2682943004: Revert of DirectCompositorFrameSink Uses CompositorFrameSinkSupport (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DirectCompositorFrameSink Uses CompositorFrameSinkSupport (patchset #39 id:830001 of https://codereview.chromium.org/2612083002/ ) Reason for revert: Causing lots of flake with Android tests https://bugs.chromium.org/p/chromium/issues/detail?id=676070. Original issue's description: > DirectCompositorFrameSink Uses CompositorFrameSinkSupport > > CompositorFrameSinkSupport is the common service-side implementation of > CompositorFrameSink. In an effort to evaluate mojo performance > independently of refactoring existing code, CompositorFrameSinkSupport > provides the same public interface as MojoCompositorFrameSink but does > not depend on mojo. > > This CL takes us in the direction of splitting DirectCompositorFrameSink > into two pieces: a client side component and a service side component. > > BUG=673543 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2612083002 > Cr-Commit-Position: refs/heads/master@{#448731} > Committed: https://chromium.googlesource.com/chromium/src/+/c405416053b99aa4d6f98f3126608c660773f6b4 TBR=reveman@chromium.org,danakj@chromium.org,fsamuel@chromium.org,jbauman@chromium.org,xlai@chromium.org,boliu@chromium.org,staraz@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=673543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -131 lines) Patch
M cc/surfaces/compositor_frame_sink_support.h View 4 chunks +14 lines, -25 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support.cc View 4 chunks +14 lines, -25 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.h View 3 chunks +8 lines, -17 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.cc View 5 chunks +34 lines, -36 lines 0 comments Download
M components/display_compositor/gpu_compositor_frame_sink.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/display_compositor/gpu_compositor_frame_sink.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/display_compositor/gpu_display_compositor_frame_sink.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/display_compositor/gpu_display_compositor_frame_sink.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M components/display_compositor/gpu_offscreen_compositor_frame_sink.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/compositor_frame_sink.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jam
Created Revert of DirectCompositorFrameSink Uses CompositorFrameSinkSupport
3 years, 10 months ago (2017-02-08 23:12:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682943004/1
3 years, 10 months ago (2017-02-08 23:12:57 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 23:15:59 UTC) #5
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

Powered by Google App Engine
This is Rietveld 408576698