Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2682853002: MD Settings: Make subpage extend to bottom of page with no overscroll (Closed)

Created:
3 years, 10 months ago by scottchen
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Make subpage extend to bottom of page with no overscroll BUG=684152 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2682853002 Cr-Commit-Position: refs/heads/master@{#449107} Committed: https://chromium.googlesource.com/chromium/src/+/a043d16382a6c55eb303da006c7378231901b704

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page_css.html View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 14 (7 generated)
scottchen
http://imgur.com/a/oUQDe
3 years, 10 months ago (2017-02-07 22:53:28 UTC) #3
scottchen
https://codereview.chromium.org/2682853002/diff/1/chrome/browser/resources/settings/settings_page_css.html File chrome/browser/resources/settings/settings_page_css.html (right): https://codereview.chromium.org/2682853002/diff/1/chrome/browser/resources/settings/settings_page_css.html#newcode19 chrome/browser/resources/settings/settings_page_css.html:19: /* The subpage container should extend to the bottom ...
3 years, 10 months ago (2017-02-07 22:55:10 UTC) #4
dpapad
LGTM
3 years, 10 months ago (2017-02-07 23:58:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682853002/1
3 years, 10 months ago (2017-02-08 00:00:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/383641)
3 years, 10 months ago (2017-02-08 01:25:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682853002/1
3 years, 10 months ago (2017-02-08 21:41:07 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 22:24:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a043d16382a6c55eb303da006c73...

Powered by Google App Engine
This is Rietveld 408576698