MD Settings: Make subpage extend to bottom of page with no overscroll

MD Settings: Make subpage extend to bottom of page with no overscroll

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2682853002
Cr-Commit-Position: refs/heads/master@{#449107}
Committed: https://chromium.googlesource.com/chromium/src/+/a043d16382a6c55eb303da006c7378231901b704

[scottchen, 2017-02-07 22:49:28]

Description was changed from

==========
MD Settings: Make subpage extend to bottom of page with no overscroll

BUG=684152
==========

to

==========
MD Settings: Make subpage extend to bottom of page with no overscroll

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-02-07 22:53:28]

scottchen@chromium.org changed reviewers:
+ dpapad@chromium.org

[scottchen, 2017-02-07 22:53:28]

http://imgur.com/a/oUQDe

[scottchen, 2017-02-07 22:55:10]

https://codereview.chromium.org/2682853002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page_css.html (right):

https://codereview.chromium.org/2682853002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page_css.html:19: /* The subpage
container should extend to the bottom of the page. */
The comment was a little confusing. According to designer, the subpage shouldn't
scroll - the scroll should still be on the viewport (and is how it currently
works).

[dpapad, 2017-02-07 23:58:11]

LGTM

[scottchen, 2017-02-07 23:59:06]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:00:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 01:25:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:25:05]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scottchen, 2017-02-08 21:40:11]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:41:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 22:23:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486590011724610, "parent_rev":
"f9ba1b6f49b1b6011aecca92e9f90dd24d7b14e9", "commit_rev":
"a043d16382a6c55eb303da006c7378231901b704"}

[commit-bot: I haz the power, 2017-02-08 22:24:07]

Description was changed from

==========
MD Settings: Make subpage extend to bottom of page with no overscroll

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Make subpage extend to bottom of page with no overscroll

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2682853002
Cr-Commit-Position: refs/heads/master@{#449107}
Committed:
https://chromium.googlesource.com/chromium/src/+/a043d16382a6c55eb303da006c73...
==========

[commit-bot: I haz the power, 2017-02-08 22:24:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a043d16382a6c55eb303da006c73...