chrome/browser/resources/settings/settings_page_css.html - Issue 2682853002: MD Settings: Make subpage extend to bottom of page with no overscroll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page_css.html

Issue 2682853002: MD Settings: Make subpage extend to bottom of page with no overscroll (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_page_css.html

diff --git a/chrome/browser/resources/settings/settings_page_css.html b/chrome/browser/resources/settings/settings_page_css.html

index 07b269dbcb5b7d8a91e69c7c6b4ac8bb702f0889..6aa289ef18703913b9e2540e76b1b80d61af3b2a 100644

--- a/chrome/browser/resources/settings/settings_page_css.html

+++ b/chrome/browser/resources/settings/settings_page_css.html

@@ -16,7 +16,7 @@

}

:host(.showing-subpage) {

- /* Set the height to the container height so the subpage scrolls. */

+ /* The subpage container should extend to the bottom of the page. */

scottchen 2017/02/07 22:55:10 The comment was a little confusing. According to d

height: 100%;

}

« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.html ('k') | no next file » | no next file with comments »