Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: chrome/browser/resources/settings/settings_page_css.html

Issue 2682853002: MD Settings: Make subpage extend to bottom of page with no overscroll (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="settings_page/main_page_behavior.html"> 2 <link rel="import" href="settings_page/main_page_behavior.html">
3 3
4 <dom-module id="settings-page-styles"> 4 <dom-module id="settings-page-styles">
5 <template> 5 <template>
6 <style> 6 <style>
7 :host { 7 :host {
8 box-sizing: border-box; 8 box-sizing: border-box;
9 display: block; 9 display: block;
10 height: inherit; 10 height: inherit;
11 margin: 0 auto; 11 margin: 0 auto;
12 max-width: calc(var(--settings-card-max-width) + 3 * 2px); 12 max-width: calc(var(--settings-card-max-width) + 3 * 2px);
13 min-width: 550px; 13 min-width: 550px;
14 position: relative; 14 position: relative;
15 width: 96%; 15 width: 96%;
16 } 16 }
17 17
18 :host(.showing-subpage) { 18 :host(.showing-subpage) {
19 /* Set the height to the container height so the subpage scrolls. */ 19 /* The subpage container should extend to the bottom of the page. */
scottchen 2017/02/07 22:55:10 The comment was a little confusing. According to d
20 height: 100%; 20 height: 100%;
21 } 21 }
22 22
23 :host > div { 23 :host > div {
24 height: inherit; 24 height: inherit;
25 } 25 }
26 26
27 :host > div > :not(.expanded) { 27 :host > div > :not(.expanded) {
28 /* The margin and padding here are doing two things: make the total 28 /* The margin and padding here are doing two things: make the total
29 * separation 24px; and make scrollIntoView align the section header 29 * separation 24px; and make scrollIntoView align the section header
30 * with the top item in the side nav menu. Both things are desired 30 * with the top item in the side nav menu. Both things are desired
31 * by Alan (bettes@). */ 31 * by Alan (bettes@). */
32 margin-bottom: 3px; 32 margin-bottom: 3px;
33 } 33 }
34 34
35 .expanded { 35 .expanded {
36 min-height: 100%; 36 min-height: 100%;
37 } 37 }
38 38
39 .expanding, 39 .expanding,
40 .collapsing { 40 .collapsing {
41 /* Must be lower than the cr-toolbar's z-index. 41 /* Must be lower than the cr-toolbar's z-index.
42 * See settings_ui.html. */ 42 * See settings_ui.html. */
43 z-index: 1; 43 z-index: 1;
44 } 44 }
45 </style> 45 </style>
46 </template> 46 </template>
47 </dom-module> 47 </dom-module>
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698