Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2682123003: Remove uses of skia::ReadPixels(PaintCanvas) (Closed)

Created:
3 years, 10 months ago by enne (OOO)
Modified:
3 years, 10 months ago
CC:
chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uses of skia::ReadPixels(PaintCanvas) PlatformCanvas's readpixels wants to operate on SkCanvas and not on PaintCanvas and won't compile once these types are different. Route gfx::Canvas users through a new gfx::Canvas API instead. BUG=671433 Review-Url: https://codereview.chromium.org/2682123003 Cr-Commit-Position: refs/heads/master@{#449706} Committed: https://chromium.googlesource.com/chromium/src/+/82f31c2e73e855f3f8b4aacc29d00bfe4c7973ba

Patch Set 1 #

Total comments: 1

Patch Set 2 : build fix #

Patch Set 3 : build fix #

Patch Set 4 : more readpixels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -41 lines) Patch
M chrome/browser/thumbnails/content_analysis_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/thumbnails/simple_thumbnail_crop_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/capturefromelement/html_video_element_capturer_source.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/gfx/color_analysis_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M ui/gfx/color_utils_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/nine_image_painter_unittest.cc View 5 chunks +5 lines, -20 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
danakj
LGTM. Can you remove skia::ReadPixels() or are there other users? https://codereview.chromium.org/2682123003/diff/1/content/renderer/media/capturefromelement/html_video_element_capturer_source.cc File content/renderer/media/capturefromelement/html_video_element_capturer_source.cc (right): https://codereview.chromium.org/2682123003/diff/1/content/renderer/media/capturefromelement/html_video_element_capturer_source.cc#newcode146 ...
3 years, 10 months ago (2017-02-09 16:27:09 UTC) #7
enne (OOO)
On 2017/02/09 at 16:27:09, danakj wrote: > LGTM. Can you remove skia::ReadPixels() or are there ...
3 years, 10 months ago (2017-02-09 18:34:45 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-10 09:05:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682123003/60001
3 years, 10 months ago (2017-02-10 18:30:55 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:55:26 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/82f31c2e73e855f3f8b4aacc29d0...

Powered by Google App Engine
This is Rietveld 408576698