Remove uses of skia::ReadPixels(PaintCanvas)

Remove uses of skia::ReadPixels(PaintCanvas)

PlatformCanvas's readpixels wants to operate on SkCanvas and not on
PaintCanvas and won't compile once these types are different.

Route gfx::Canvas users through a new gfx::Canvas API instead.

BUG=671433
Review-Url: https://codereview.chromium.org/2682123003
Cr-Commit-Position: refs/heads/master@{#449706}
Committed: https://chromium.googlesource.com/chromium/src/+/82f31c2e73e855f3f8b4aacc29d00bfe4c7973ba

[enne (OOO), 2017-02-09 02:11:04]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[enne (OOO), 2017-02-09 02:11:10]

enne@chromium.org changed reviewers:
+ danakj@chromium.org

[commit-bot: I haz the power, 2017-02-09 02:11:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-02-09 02:12:14]

enne@chromium.org changed reviewers:
+ jochen@chromium.org

[commit-bot: I haz the power, 2017-02-09 02:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 02:35:00]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2017-02-09 16:27:09]

LGTM. Can you remove skia::ReadPixels() or are there other users?

https://codereview.chromium.org/2682123003/diff/1/content/renderer/media/capt...
File
content/renderer/media/capturefromelement/html_video_element_capturer_source.cc
(right):

https://codereview.chromium.org/2682123003/diff/1/content/renderer/media/capt...
content/renderer/media/capturefromelement/html_video_element_capturer_source.cc:146:
const SkBitmap bitmap = canvas.ToBitmap();
canvas->

[enne (OOO), 2017-02-09 18:34:16]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[enne (OOO), 2017-02-09 18:34:45]

On 2017/02/09 at 16:27:09, danakj wrote:
> LGTM. Can you remove skia::ReadPixels() or are there other users?

There are some other users.  I think it's just as useful as
gfx::Canvas::ToBitmap, but it just operates on SkCanvas instead.

[commit-bot: I haz the power, 2017-02-09 18:35:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 18:48:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 18:48:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[enne (OOO), 2017-02-09 19:15:02]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 19:15:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-02-10 09:05:47]

lgtm

[enne (OOO), 2017-02-10 16:59:32]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2017-02-10 16:59:33]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2682123003/#ps60001
(title: "more readpixels")

[enne (OOO), 2017-02-10 16:59:42]

The CQ bit was unchecked by enne@chromium.org

[enne (OOO), 2017-02-10 18:30:12]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2017-02-10 18:30:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 19:54:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486751412622180,
"parent_rev": "98e40547c25195c145bf19c9272ca50e88db4d43", "commit_rev":
"82f31c2e73e855f3f8b4aacc29d00bfe4c7973ba"}

[commit-bot: I haz the power, 2017-02-10 19:55:25]

Description was changed from

==========
Remove uses of skia::ReadPixels(PaintCanvas)

PlatformCanvas's readpixels wants to operate on SkCanvas and not on
PaintCanvas and won't compile once these types are different.

Route gfx::Canvas users through a new gfx::Canvas API instead.

BUG=671433
==========

to

==========
Remove uses of skia::ReadPixels(PaintCanvas)

PlatformCanvas's readpixels wants to operate on SkCanvas and not on
PaintCanvas and won't compile once these types are different.

Route gfx::Canvas users through a new gfx::Canvas API instead.

BUG=671433

Review-Url: https://codereview.chromium.org/2682123003
Cr-Commit-Position: refs/heads/master@{#449706}
Committed:
https://chromium.googlesource.com/chromium/src/+/82f31c2e73e855f3f8b4aacc29d0...
==========

[commit-bot: I haz the power, 2017-02-10 19:55:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/82f31c2e73e855f3f8b4aacc29d0...