content/renderer/media/capturefromelement/html_video_element_capturer_source.cc - Issue 2682123003: Remove uses of skia::ReadPixels(PaintCanvas)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/capturefromelement/html_video_element_capturer_source.cc

Issue 2682123003: Remove uses of skia::ReadPixels(PaintCanvas) (Closed)

Patch Set: more readpixels Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/thumbnails/simple_thumbnail_crop_unittest.cc ('k') | content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/capturefromelement/html_video_element_capturer_source.cc

diff --git a/content/renderer/media/capturefromelement/html_video_element_capturer_source.cc b/content/renderer/media/capturefromelement/html_video_element_capturer_source.cc

index 78bbdc2a97593c00a63393d5978cbe9433ece39e..7120f8d3abd1f57601a50a8901b11f9379d68575 100644

--- a/content/renderer/media/capturefromelement/html_video_element_capturer_source.cc

+++ b/content/renderer/media/capturefromelement/html_video_element_capturer_source.cc

@@ -143,7 +143,10 @@ void HtmlVideoElementCapturerSource::sendNewFrame() {

DCHECK_EQ(canvas->imageInfo().width(), resolution.width);

DCHECK_EQ(canvas->imageInfo().height(), resolution.height);

- const SkBitmap bitmap = skia::ReadPixels(canvas);

+ SkBitmap bitmap;

+ bitmap.setInfo(canvas->imageInfo());

+ canvas->readPixels(&bitmap, 0, 0);

DCHECK_NE(kUnknown_SkColorType, bitmap.colorType());

DCHECK(!bitmap.drawsNothing());

DCHECK(bitmap.getPixels());