chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc - Issue 2682123003: Remove uses of skia::ReadPixels(PaintCanvas)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc

Issue 2682123003: Remove uses of skia::ReadPixels(PaintCanvas) (Closed)

Patch Set: more readpixels Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/thumbnails/content_analysis_unittest.cc ('k') | chrome/browser/thumbnails/simple_thumbnail_crop_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc

diff --git a/chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc b/chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc

index d94af95fc4a394f6ef3362b0d440c16bf0400cb7..ef13e4019f30e0014a450bbf7d518e82e3b103b0 100644

--- a/chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc

+++ b/chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc

@@ -140,7 +140,7 @@ TEST_F(ContentBasedThumbnailingAlgorithmTest, CreateRetargetedThumbnail) {

// The image consists of vertical non-overlapping stripes 150 pixels wide.

canvas.FillRect(gfx::Rect(200, 200, 800, 400), SkColorSetRGB(255, 255, 255));

- SkBitmap source = skia::ReadPixels(canvas.sk_canvas());

+ SkBitmap source = canvas.ToBitmap();

ConsumerCallbackCatcher catcher;

const gfx::Size thumbnail_size(432, 284);