Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2681443003: Send click event after pointer capturing retarget (Closed)
Patch Set: Rename the function and the parameter names Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index e07154a7cf1994e6dc60f8036f1cee7dea2aab71..39d1f5e2a2cc5f06d17066e9f31afd7c2641ff91 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -978,10 +978,9 @@ WebInputEventResult EventHandler::handleMouseReleaseEvent(
WebInputEventResult eventResult = updatePointerTargetAndDispatchEvents(
EventTypeNames::mouseup, mev.innerNode(), mev.canvasRegionId(),
- mev.event(), Vector<WebMouseEvent>());
-
- WebInputEventResult clickEventResult =
- m_mouseEventManager->dispatchMouseClickIfNeeded(mev);
+ mev.event(), Vector<WebMouseEvent>(),
+ !(selectionController().hasExtendedSelection() &&
+ isSelectionOverLink(mev)));
m_scrollManager->clearResizeScrollableArea(false);
@@ -991,7 +990,7 @@ WebInputEventResult EventHandler::handleMouseReleaseEvent(
m_mouseEventManager->invalidateClick();
- return EventHandlingUtil::mergeEventResult(clickEventResult, eventResult);
+ return eventResult;
}
static bool targetIsFrame(Node* target, LocalFrame*& frame) {
@@ -1266,14 +1265,15 @@ WebInputEventResult EventHandler::updatePointerTargetAndDispatchEvents(
Node* targetNode,
const String& canvasRegionId,
const WebMouseEvent& mouseEvent,
- const Vector<WebMouseEvent>& coalescedEvents) {
+ const Vector<WebMouseEvent>& coalescedEvents,
+ bool selectionOverLink) {
ASSERT(mouseEventType == EventTypeNames::mousedown ||
mouseEventType == EventTypeNames::mousemove ||
mouseEventType == EventTypeNames::mouseup);
const auto& eventResult = m_pointerEventManager->sendMousePointerEvent(
updateMouseEventTargetNode(targetNode), canvasRegionId, mouseEventType,
- mouseEvent, coalescedEvents);
+ mouseEvent, coalescedEvents, selectionOverLink);
return eventResult;
}
« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.h ('k') | third_party/WebKit/Source/core/input/MouseEventManager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698