Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2681443003: Send click event after pointer capturing retarget (Closed)
Patch Set: Rename the function and the parameter names Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index c706599cd6bcf72168b47675f9d24d1aef2f2c1b..a84be9c1f3fa26aaa1e88944e4463dc0d47f98d8 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -784,9 +784,9 @@ void SelectionController::handleMousePressEvent(
const MouseEventWithHitTestResults& event) {
// If we got the event back, that must mean it wasn't prevented,
// so it's allowed to start a drag or selection if it wasn't in a scrollbar.
- m_mouseDownMayStartSelect =
- (canMouseDownStartSelect(event.innerNode()) || isLinkSelection(event)) &&
- !event.scrollbar();
+ m_mouseDownMayStartSelect = (canMouseDownStartSelect(event.innerNode()) ||
+ isSelectionOverLink(event)) &&
+ !event.scrollbar();
m_mouseDownWasSingleClickInSelection = false;
if (!selection().isAvailable()) {
// "gesture-tap-frame-removed.html" reaches here.
@@ -1079,7 +1079,7 @@ FrameSelection& SelectionController::selection() const {
return m_frame->selection();
}
-bool isLinkSelection(const MouseEventWithHitTestResults& event) {
+bool isSelectionOverLink(const MouseEventWithHitTestResults& event) {
return (event.event().modifiers() & WebInputEvent::Modifiers::AltKey) != 0 &&
event.isOverLink();
}
« no previous file with comments | « third_party/WebKit/Source/core/editing/SelectionController.h ('k') | third_party/WebKit/Source/core/input/EventHandler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698