Remove replaceComposition() calls in finishComposingText.

Remove replaceComposition() calls in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary work
in general, and the input/compositionupdate events are just repeated from the last
setComposition() call.  So just clean them out and have a clear()/moveCaret() call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextDoesntTriggerAutofillTextChange
BUG=681822
Review-Url: https://codereview.chromium.org/2664603002
Cr-Original-Commit-Position: refs/heads/master@{#448546}
Review-Url: https://codereview.chromium.org/2681023003 .
Cr-Commit-Position: refs/branch-heads/2987@{#381}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/b1b55fb2cf97a6274212b1f288ea20efff471901

[aelias_OOO_until_Jul13, 2017-02-08 03:57:27]

Description was changed from

==========
Remove replaceComposition() calls in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextDoesntTriggerAutofillTextChange
BUG=681822

Review-Url: https://codereview.chromium.org/2664603002
Cr-Commit-Position: refs/heads/master@{#448546}
==========

to

==========
Remove replaceComposition() calls in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextDoesntTriggerAutofillTextChange
BUG=681822

Review-Url: https://codereview.chromium.org/2664603002
Cr-Original-Commit-Position: refs/heads/master@{#448546}
Review-Url: https://codereview.chromium.org/2681023003 .
Cr-Commit-Position: refs/branch-heads/2987@{#381}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1b55fb2cf97a6274212b1f288ea...
==========

[aelias_OOO_until_Jul13, 2017-02-08 03:57:28]

Committed patchset #1 (id:1) manually as
b1b55fb2cf97a6274212b1f288ea20efff471901.