content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java - Issue 2681023003: Remove replaceComposition() calls in finishComposingText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 2681023003: Remove replaceComposition() calls in finishComposingText. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/autofill_agent.cc ('k') | third_party/WebKit/LayoutTests/fast/events/composition-event-source-device-event-sender-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

index 8b16ed9338effead8f88e12988076d94a94d47c4..ab7c2c97ac3a6d339666c4de0ac014060b0cacc2 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

@@ -1213,9 +1213,8 @@ public class ImeTest extends ContentShellTestBase {

finishComposingText();

waitAndVerifyUpdateSelection(1, 1, 1, -1, -1);

- // TODO(changwan): reduce the number of selection changes.

waitForEventLogs(

- "compositionupdate(a),input,compositionend(a),selectionchange,selectionchange");

+ "compositionend(a)");

}

@MediumTest

@@ -1230,9 +1229,7 @@ public class ImeTest extends ContentShellTestBase {

finishComposingText();

waitAndVerifyUpdateSelection(1, 1, 1, -1, -1);

- // TODO(changwan): reduce the number of selection changes.

- waitForEventLogs("compositionupdate(a),input,compositionend(a),selectionchange,"

- + "selectionchange,selectionchange");

+ waitForEventLogs("compositionend(a)");

}

@MediumTest