Remove replaceComposition() calls in finishComposingText.

Remove replaceComposition() calls in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary work
in general, and the input/compositionupdate events are just repeated from the last
setComposition() call.  So just clean them out and have a clear()/moveCaret() call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextDoesntTriggerAutofillTextChange
BUG=681822
Review-Url: https://codereview.chromium.org/2664603002
Cr-Commit-Position: refs/heads/master@{#448546}
Committed: https://chromium.googlesource.com/chromium/src/+/81279cd5b209a34ca4f7702f2a10576faa50fdf9

[aelias_OOO_until_Jul13, 2017-01-28 00:23:40]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 00:24:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 00:27:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 00:27:45]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[aelias_OOO_until_Jul13, 2017-01-28 00:48:05]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 00:48:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 01:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 01:39:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aelias_OOO_until_Jul13, 2017-01-28 02:02:56]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 02:03:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-01-28 02:04:28]

Description was changed from

==========
[WIP] Early-return for no-op set to HTMLInputElement.

In http://crrev.com/2530843003, we purposely made finishComposingText go
through all of the normal low-level 'insert' calls even if it doesn't
change the text at all.  This has the benefit of unifying the code flow so
that side effects like 'compositionend' events occur.  But it means code
lower down needs to early-return.

BUG=681822
==========

to

==========
[WIP] Avoid autofill side effects in finishComposingText



BUG=681822
==========

[aelias_OOO_until_Jul13, 2017-01-28 02:56:22]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 02:56:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-01-28 03:14:51]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 03:15:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-01-28 04:31:48]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 04:31:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-01-28 05:08:34]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 05:08:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-01-28 05:19:45]

Description was changed from

==========
[WIP] Avoid autofill side effects in finishComposingText



BUG=681822
==========

to

==========
Remove replace operation in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

BUG=681822
==========

[aelias_OOO_until_Jul13, 2017-01-28 05:20:18]

Description was changed from

==========
Remove replace operation in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

BUG=681822
==========

to

==========
Remove replace operation in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextTriggersAutofillTextChange
BUG=681822
==========

[aelias_OOO_until_Jul13, 2017-01-28 05:20:44]

Description was changed from

==========
Remove replace operation in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextTriggersAutofillTextChange
BUG=681822
==========

to

==========
Remove replaceComposition() calls in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextTriggersAutofillTextChange
BUG=681822
==========

[aelias_OOO_until_Jul13, 2017-01-28 05:22:25]

aelias@chromium.org changed reviewers:
+ sebsg@chromium.org, yosin@chromium.org

[aelias_OOO_until_Jul13, 2017-01-28 05:22:25]

PTAL:
yosin@ for core/editing
sebsg@ for code deletion in components/autofill/

[yabinh, 2017-01-28 06:10:58]

yabinh@chromium.org changed reviewers:
+ yabinh@chromium.org

[yabinh, 2017-01-28 06:10:59]

https://codereview.chromium.org/2664603002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/tests/WebViewTest.cpp (right):

https://codereview.chromium.org/2664603002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/tests/WebViewTest.cpp:2874: TEST_P(WebViewTest,
SetCompositionFromExistingTextTriggersAutofillTextChange) {
The name should be ...DoesntTrigger...?

[commit-bot: I haz the power, 2017-01-28 06:19:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 06:19:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aelias_OOO_until_Jul13, 2017-01-28 06:38:08]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 06:38:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-01-28 06:38:49]

https://codereview.chromium.org/2664603002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/tests/WebViewTest.cpp (right):

https://codereview.chromium.org/2664603002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/tests/WebViewTest.cpp:2874: TEST_P(WebViewTest,
SetCompositionFromExistingTextTriggersAutofillTextChange) {
On 2017/01/28 at 06:10:59, yabinh wrote:
> The name should be ...DoesntTrigger...?

Done.

[commit-bot: I haz the power, 2017-01-28 09:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 09:14:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sebsg, 2017-02-02 14:55:34]

lgtm for components/autofill

[aelias_OOO_until_Jul13, 2017-02-04 02:25:42]

yosin@, ping for core/editing review.

[yosin_UTC9, 2017-02-06 04:47:18]

lgtm for core/editing

[aelias_OOO_until_Jul13, 2017-02-07 00:18:19]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2017-02-07 00:19:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 00:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 00:23:24]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[aelias_OOO_until_Jul13, 2017-02-07 01:17:50]

Description was changed from

==========
Remove replaceComposition() calls in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextTriggersAutofillTextChange
BUG=681822
==========

to

==========
Remove replaceComposition() calls in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextDoesntTriggerAutofillTextChange
BUG=681822
==========

[aelias_OOO_until_Jul13, 2017-02-07 01:17:58]

The CQ bit was checked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2017-02-07 01:17:58]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2664603002/#ps180001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-07 01:18:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 04:46:27]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1486430278177680,
"parent_rev": "c28047f0537c6ca0718428081abacb913bc106a7", "commit_rev":
"81279cd5b209a34ca4f7702f2a10576faa50fdf9"}

[commit-bot: I haz the power, 2017-02-07 04:47:28]

Description was changed from

==========
Remove replaceComposition() calls in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextDoesntTriggerAutofillTextChange
BUG=681822
==========

to

==========
Remove replaceComposition() calls in finishComposingText.

We recently split commitText("") into a new method finishComposingText, a no-op
commit that simply preserves the already existing composition.  But because
of its historical origins it still had the replaceComposition call in it.

This is causing a bug with "yellow" autofill status getting cleared due
to the operation being interpreted as user typing.  But also, it's unnecessary
work
in general, and the input/compositionupdate events are just repeated from the
last
setComposition() call.  So just clean them out and have a clear()/moveCaret()
call.

As a result of this, I was also able to clean out another longstanding autofill
ignoring flag that no longer has anything to ignore.

TEST=WebViewTest.FinishComposingTextDoesntTriggerAutofillTextChange
BUG=681822

Review-Url: https://codereview.chromium.org/2664603002
Cr-Commit-Position: refs/heads/master@{#448546}
Committed:
https://chromium.googlesource.com/chromium/src/+/81279cd5b209a34ca4f7702f2a10...
==========

[commit-bot: I haz the power, 2017-02-07 04:47:29]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/81279cd5b209a34ca4f7702f2a10...