Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2680923003: Revert of Thread maybe-assigned through the bytecodes. (Closed)

Created:
3 years, 10 months ago by Michael Hablich
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy, neis, danno
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Thread maybe-assigned through the bytecodes. (patchset #5 id:80001 of https://codereview.chromium.org/2655733003/ ) Reason for revert: needed for properly reverting https://chromium.googlesource.com/v8/v8/+/f3ae5ccf57690d8c2d87c4fe1d10b103ad6a4ab3 Original issue's description: > Thread maybe-assigned through the bytecodes. > > This introduces LoadImmutableContextSlot and LoadImmutableCurrentContextSlot > bytecodes, which are emitted when reading from never-assigned context slot. > > There is a subtlety here: the slot are not immutable, the meaning is > actually undefined-or-hole-or-immutable. > > Review-Url: https://codereview.chromium.org/2655733003 > Cr-Commit-Position: refs/heads/master@{#43000} > Committed: https://chromium.googlesource.com/v8/v8/+/17c2dd388697da626224c371c8181d20d2016d82 TBR=rmcilroy@chromium.org,bmeurer@chromium.org,neis@chromium.org,jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2680923003 Cr-Commit-Position: refs/heads/master@{#43011} Committed: https://chromium.googlesource.com/v8/v8/+/ece4e54a31ac76ee9c450270d65270562db716e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -453 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 2 chunks +6 lines, -18 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +5 lines, -13 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 4 chunks +7 lines, -19 lines 0 comments Download
M src/interpreter/bytecodes.h View 2 chunks +283 lines, -288 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Delete.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 9 chunks +13 lines, -13 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LetVariableContextSlot.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 12 chunks +26 lines, -26 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/OuterContextVariables.golden View 2 chunks +3 lines, -3 lines 0 comments Download
D test/mjsunit/immutable-context-slot-inlining.js View 1 chunk +0 lines, -30 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Hablich
Created Revert of Thread maybe-assigned through the bytecodes.
3 years, 10 months ago (2017-02-07 20:19:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680923003/1
3 years, 10 months ago (2017-02-07 20:19:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/ece4e54a31ac76ee9c450270d65270562db716e1
3 years, 10 months ago (2017-02-07 20:19:31 UTC) #6
Michael Hablich
3 years, 10 months ago (2017-02-07 20:41:44 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2679953003/ by hablich@chromium.org.

The reason for reverting is: False alarm, bot hiccup.

Powered by Google App Engine
This is Rietveld 408576698