Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 2680923003: Revert of Thread maybe-assigned through the bytecodes. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/bytecode-graph-builder.cc
diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc
index 4b2abad3dd3d23c579541519cb08314355494451..d9f52a61b76ad03a381b3fbab4645ef6013da33c 100644
--- a/src/compiler/bytecode-graph-builder.cc
+++ b/src/compiler/bytecode-graph-builder.cc
@@ -770,6 +770,9 @@
}
void BytecodeGraphBuilder::VisitLdaContextSlot() {
+ // TODO(mythria): immutable flag is also set to false. This information is not
+ // available in bytecode array. update this code when the implementation
+ // changes.
const Operator* op = javascript()->LoadContext(
bytecode_iterator().GetUnsignedImmediateOperand(2),
bytecode_iterator().GetIndexOperand(1), false);
@@ -780,27 +783,12 @@
environment()->BindAccumulator(node);
}
-void BytecodeGraphBuilder::VisitLdaImmutableContextSlot() {
- const Operator* op = javascript()->LoadContext(
- bytecode_iterator().GetUnsignedImmediateOperand(2),
- bytecode_iterator().GetIndexOperand(1), true);
- Node* node = NewNode(op);
- Node* context =
- environment()->LookupRegister(bytecode_iterator().GetRegisterOperand(0));
- NodeProperties::ReplaceContextInput(node, context);
- environment()->BindAccumulator(node);
-}
-
void BytecodeGraphBuilder::VisitLdaCurrentContextSlot() {
+ // TODO(mythria): immutable flag is also set to false. This information is not
+ // available in bytecode array. update this code when the implementation
+ // changes.
const Operator* op = javascript()->LoadContext(
0, bytecode_iterator().GetIndexOperand(0), false);
- Node* node = NewNode(op);
- environment()->BindAccumulator(node);
-}
-
-void BytecodeGraphBuilder::VisitLdaImmutableCurrentContextSlot() {
- const Operator* op = javascript()->LoadContext(
- 0, bytecode_iterator().GetIndexOperand(0), true);
Node* node = NewNode(op);
environment()->BindAccumulator(node);
}
« no previous file with comments | « no previous file | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698