Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2680463002: Convert ContentPasswordManagerDriver to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
vasilii
CC:
chromium-reviews, jam, gcasto+watchlist_chromium.org, darin-cc_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ContentPasswordManagerDriver to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2680463002 Cr-Commit-Position: refs/heads/master@{#448287} Committed: https://chromium.googlesource.com/chromium/src/+/9dc4cb62fe2430bd141c596e37634fd2985acb2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M components/password_manager/content/browser/content_password_manager_driver.h View 2 chunks +2 lines, -4 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver_factory.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver_factory.cc View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 10 months ago (2017-02-06 17:01:51 UTC) #7
vasilii
lgtm
3 years, 10 months ago (2017-02-06 17:24:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680463002/1
3 years, 10 months ago (2017-02-06 17:27:04 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 17:39:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9dc4cb62fe2430bd141c596e3763...

Powered by Google App Engine
This is Rietveld 408576698