components/password_manager/content/browser/content_password_manager_driver_factory.h - Issue 2680463002: Convert ContentPasswordManagerDriver to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver_factory.h

Issue 2680463002: Convert ContentPasswordManagerDriver to use the new navigation callbacks. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/content_password_manager_driver.cc ('k') | components/password_manager/content/browser/content_password_manager_driver_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver_factory.h

diff --git a/components/password_manager/content/browser/content_password_manager_driver_factory.h b/components/password_manager/content/browser/content_password_manager_driver_factory.h

index 2c2e4cdc221276f1d811f9a0e6eca607f0d1204c..184489826d64de84817acb3481a560232cb1e93c 100644

--- a/components/password_manager/content/browser/content_password_manager_driver_factory.h

+++ b/components/password_manager/content/browser/content_password_manager_driver_factory.h

@@ -59,9 +59,8 @@ class ContentPasswordManagerDriverFactory

// content::WebContentsObserver:

void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;

void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;

- void DidNavigateAnyFrame(content::RenderFrameHost* render_frame_host,

- const content::LoadCommittedDetails& details,

- const content::FrameNavigateParams& params) override;

+ void DidFinishNavigation(

+ content::NavigationHandle* navigation_handle) override;

private:

ContentPasswordManagerDriverFactory(