Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver_factory.cc

Issue 2680463002: Convert ContentPasswordManagerDriver to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/content/browser/content_password_manager_driver_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/content_password_manager_driver_factory.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver_factory.cc b/components/password_manager/content/browser/content_password_manager_driver_factory.cc
index 809b6a81aebae2395f89a71421a9c0bd5f1cff76..c84117f9fc74bb84e11534277773dad2af3e7615 100644
--- a/components/password_manager/content/browser/content_password_manager_driver_factory.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver_factory.cc
@@ -16,8 +16,8 @@
#include "components/password_manager/content/browser/content_password_manager_driver.h"
#include "components/password_manager/core/browser/password_manager_client.h"
#include "content/public/browser/browser_context.h"
-#include "content/public/browser/navigation_details.h"
#include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/ssl_status.h"
@@ -145,12 +145,13 @@ void ContentPasswordManagerDriverFactory::RenderFrameDeleted(
frame_driver_map_.erase(render_frame_host);
}
-void ContentPasswordManagerDriverFactory::DidNavigateAnyFrame(
- content::RenderFrameHost* render_frame_host,
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) {
- frame_driver_map_.find(render_frame_host)
- ->second->DidNavigateFrame(details, params);
+void ContentPasswordManagerDriverFactory::DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) {
+ if (!navigation_handle->HasCommitted())
+ return;
+
+ frame_driver_map_.find(navigation_handle->GetRenderFrameHost())
+ ->second->DidNavigateFrame(navigation_handle);
}
void ContentPasswordManagerDriverFactory::RequestSendLoggingAvailability() {
« no previous file with comments | « components/password_manager/content/browser/content_password_manager_driver_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698