Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2039)

Issue 2680313008: Remove BrowserViewController -tabForWebState:. (Closed)

Created:
3 years, 10 months ago by sdefresne
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove BrowserViewController -tabForWebState:. Use LegacyTabHelper to convert a WebState to a Tab in the BrowserViewController implementation and remove the helper class that iterated over TabModel. BUG=None Review-Url: https://codereview.chromium.org/2680313008 Cr-Commit-Position: refs/heads/master@{#449298} Committed: https://chromium.googlesource.com/chromium/src/+/0452a9d5c152a81bdbbc2ad5fa4bc7ac95094b3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M ios/chrome/browser/tabs/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 5 chunks +4 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
sdefresne
Please take a look.
3 years, 10 months ago (2017-02-09 13:37:52 UTC) #3
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-09 13:39:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680313008/1
3 years, 10 months ago (2017-02-09 15:29:42 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 15:34:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0452a9d5c152a81bdbbc2ad5fa4b...

Powered by Google App Engine
This is Rietveld 408576698