Remove BrowserViewController -tabForWebState:.

ios/chrome/browser/ui/browser_view_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 
 #import <AssetsLibrary/AssetsLibrary.h>
 #import <MobileCoreServices/MobileCoreServices.h>
 #import <PassKit/PassKit.h>
 #import <Photos/Photos.h>
@@ skipping 59 matching lines @@
 #include "ios/chrome/browser/pref_names.h"
 #include "ios/chrome/browser/reading_list/reading_list_model_factory.h"
 #include "ios/chrome/browser/search_engines/template_url_service_factory.h"
 #include "ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.h"
 #include "ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.h"
 #include "ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios_factory.h"
 #import "ios/chrome/browser/snapshots/snapshot_cache.h"
 #import "ios/chrome/browser/snapshots/snapshot_overlay.h"
 #import "ios/chrome/browser/snapshots/snapshot_overlay_provider.h"
 #import "ios/chrome/browser/storekit_launcher.h"
+#import "ios/chrome/browser/tabs/legacy_tab_helper.h"
 #import "ios/chrome/browser/tabs/tab.h"
 #import "ios/chrome/browser/tabs/tab_dialog_delegate.h"
 #import "ios/chrome/browser/tabs/tab_headers_delegate.h"
 #import "ios/chrome/browser/tabs/tab_model.h"
 #import "ios/chrome/browser/tabs/tab_model_observer.h"
 #import "ios/chrome/browser/tabs/tab_snapshotting_delegate.h"
 #import "ios/chrome/browser/ui/activity_services/chrome_activity_item_thumbnail_generator.h"
 #import "ios/chrome/browser/ui/activity_services/share_protocol.h"
 #import "ios/chrome/browser/ui/activity_services/share_to_data.h"
 #import "ios/chrome/browser/ui/activity_services/share_to_data_builder.h"
@@ skipping 578 matching lines @@
 // Shows an alert with the given title and message id.
 - (void)showErrorAlert:(int)titleMessageId message:(int)messageId;
 // Helper method displaying an alert with the given title and message.
 // Dismisses previous alert if it has not been dismissed yet.
 - (void)showErrorAlertWithStringTitle:(NSString*)title
                               message:(NSString*)message;
 // Shows a self-dismissing snackbar displaying |message|.
 - (void)showSnackbar:(NSString*)message;
 // Induces an intentional crash in the browser process.
 - (void)induceBrowserCrash;
-// Returns Tab that corresponds to the given |webState|.
-- (Tab*)tabForWebState:(web::WebState*)webState;
 // Saves the image or display error message, based on privacy settings.
 - (void)managePermissionAndSaveImage:(NSData*)data;
 // Saves the image. In order to keep the metadata of the image, the image is
 // saved as a temporary file on disk then saved in photos.
 // This should be called on FILE thread.
 - (void)saveImage:(NSData*)data;
 // Called when Chrome has been denied access to the photos or videos and the
 // user can change it.
 // Shows a privacy alert on the main queue, allowing the user to go to Chrome's
 // settings. Dismiss previous alert if it has not been dismissed yet.
@@ skipping 1636 matching lines @@
 - (web::WebState*)webState:(web::WebState*)webState
          openURLWithParams:(const web::WebState::OpenURLParams&)params {
   switch (params.disposition) {
     case WindowOpenDisposition::NEW_FOREGROUND_TAB:
     case WindowOpenDisposition::NEW_BACKGROUND_TAB: {
       Tab* tab = [[self tabModel]
           insertOrUpdateTabWithURL:params.url
                           referrer:params.referrer
                         transition:params.transition
                         windowName:nil
-                            opener:[self tabForWebState:webState]
+                            opener:LegacyTabHelper::GetTabForWebState(webState)
                        openedByDOM:NO
                            atIndex:TabModelConstants::kTabPositionAutomatically
                       inBackground:(params.disposition ==
                                     WindowOpenDisposition::NEW_BACKGROUND_TAB)];
       return tab.webState;
     }
     case WindowOpenDisposition::CURRENT_TAB: {
       web::NavigationManager::WebLoadParams loadParams(params.url);
       loadParams.referrer = params.referrer;
       loadParams.transition_type = params.transition;
@@ skipping 154 matching lines @@
   }
 
   [_contextMenuCoordinator start];
   return YES;
 }
 
 - (void)webState:(web::WebState*)webState
     runRepostFormDialogWithCompletionHandler:(void (^)(BOOL))handler {
   // Display the action sheet with the arrow pointing at the top center of the
   // web contents.
+  Tab* tab = LegacyTabHelper::GetTabForWebState(webState);
   UIView* view = webState->GetView();
   CGPoint dialogLocation =
       CGPointMake(CGRectGetMidX(view.frame),
-                  CGRectGetMinY(view.frame) +
-                      [self headerHeightForTab:[self tabForWebState:webState]]);
+                  CGRectGetMinY(view.frame) + [self headerHeightForTab:tab]);
   auto helper = RepostFormTabHelper::FromWebState(webState);
   helper->PresentDialog(dialogLocation, base::BindBlock(^(bool shouldContinue) {
                           handler(shouldContinue);
                         }));
 }
 
 - (web::JavaScriptDialogPresenter*)javaScriptDialogPresenterForWebState:
     (web::WebState*)webState {
   return _javaScriptDialogPresenter.get();
 }
@@ skipping 1059 matching lines @@
   [_preloadController cancelPrerender];
   DCHECK([_model currentTab]);
   [[_model currentTab].webController executeUserJavaScript:script
                                          completionHandler:nil];
 }
 
 - (web::WebState*)currentWebState {
   return [[_model currentTab] webState];
 }
 
-- (Tab*)tabForWebState:(web::WebState*)webState {
-  for (Tab* tab in _model.get()) {
-    if (tab.webState == webState)
-      return tab;
-  }
-  return nil;
-}
-
 // This is called from within an animation block.
 - (void)toolbarHeightChanged {
   if ([self headerHeight] != 0) {
     // Ensure full screen height is updated.
     Tab* currentTab = [_model currentTab];
     BOOL visible = self.isToolbarOnScreen;
     [currentTab updateFullscreenWithToolbarVisible:visible];
   }
 }
 
@@ skipping 1349 matching lines @@
 
 - (UIView*)voiceSearchButton {
   return _voiceSearchButton;
 }
 
 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
   return [self currentLogoAnimationControllerOwner];
 }
 
 @end