Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2681843002: Add mechanism to get the Tab from the associated WebState. (Closed)

Created:
3 years, 10 months ago by sdefresne
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mechanism to get the Tab from the associated WebState. BUG=687207 Review-Url: https://codereview.chromium.org/2681843002 Cr-Commit-Position: refs/heads/master@{#449274} Committed: https://chromium.googlesource.com/chromium/src/+/75ec07fd18d0f575744802610ffba4d021748022

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M ios/chrome/browser/tabs/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/legacy_tab_helper.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/legacy_tab_helper.mm View 1 1 chunk +34 lines, -0 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 3 chunks +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
sdefresne
Please take a look.
3 years, 10 months ago (2017-02-07 18:09:43 UTC) #2
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/2681843002/diff/1/ios/chrome/browser/tabs/legacy_tab_helper.h File ios/chrome/browser/tabs/legacy_tab_helper.h (right): https://codereview.chromium.org/2681843002/diff/1/ios/chrome/browser/tabs/legacy_tab_helper.h#newcode14 ios/chrome/browser/tabs/legacy_tab_helper.h:14: class LegacyTabHelper : public web::WebStateUserData<LegacyTabHelper> { Class could ...
3 years, 10 months ago (2017-02-08 14:07:17 UTC) #3
rohitrao (ping after 24h)
https://codereview.chromium.org/2681843002/diff/1/ios/chrome/browser/tabs/BUILD.gn File ios/chrome/browser/tabs/BUILD.gn (right): https://codereview.chromium.org/2681843002/diff/1/ios/chrome/browser/tabs/BUILD.gn#newcode33 ios/chrome/browser/tabs/BUILD.gn:33: "legacy_tab_helper.h", Should we make this an ARC file?
3 years, 10 months ago (2017-02-08 14:07:48 UTC) #4
sdefresne
PTAL https://codereview.chromium.org/2681843002/diff/1/ios/chrome/browser/tabs/BUILD.gn File ios/chrome/browser/tabs/BUILD.gn (right): https://codereview.chromium.org/2681843002/diff/1/ios/chrome/browser/tabs/BUILD.gn#newcode33 ios/chrome/browser/tabs/BUILD.gn:33: "legacy_tab_helper.h", On 2017/02/08 14:07:48, rohitrao wrote: > Should ...
3 years, 10 months ago (2017-02-08 14:45:34 UTC) #6
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-08 14:54:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681843002/40001
3 years, 10 months ago (2017-02-09 13:03:17 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 13:09:00 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/75ec07fd18d0f575744802610ffb...

Powered by Google App Engine
This is Rietveld 408576698