Replace va_arg version of crypto_test_utils::Message with a more modern vector argument version.

net/quic/test_tools/crypto_test_utils_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/test_tools/crypto_test_utils.h"
 
 #include "net/quic/core/crypto/crypto_server_config_protobuf.h"
 #include "net/quic/core/quic_utils.h"
 #include "net/quic/platform/api/quic_text_utils.h"
 #include "net/quic/test_tools/mock_clock.h"
@@ skipping 130 matching lines @@
                   sizeof(orbit.size())),
       &nonce);
   string nonce_hex = "#" + QuicTextUtils::HexEncode(nonce);
 
   char public_value[32];
   memset(public_value, 42, sizeof(public_value));
   string pub_hex =
       "#" + QuicTextUtils::HexEncode(public_value, sizeof(public_value));
 
   QuicVersion version(AllSupportedVersions().front());
-  // clang-format off
-  CryptoHandshakeMessage inchoate_chlo = crypto_test_utils::Message(
-    "CHLO",
-    "PDMD", "X509",
-    "AEAD", "AESG",
-    "KEXS", "C255",
-    "COPT", "SREJ",
-    "PUBS", pub_hex.c_str(),
-    "NONC", nonce_hex.c_str(),
-    "VER\0", QuicTagToString(QuicVersionToQuicTag(version)).c_str(),
-    "$padding", static_cast<int>(kClientHelloMinimumSize),
-    nullptr);
-  // clang-format on
+  CryptoHandshakeMessage inchoate_chlo = crypto_test_utils::CreateCHLO(
+      {{"PDMD", "X509"},
+       {"AEAD", "AESG"},
+       {"KEXS", "C255"},
+       {"COPT", "SREJ"},
+       {"PUBS", pub_hex},
+       {"NONC", nonce_hex},
+       {"VER\0", QuicTagToString(QuicVersionToQuicTag(version))}},
+      kClientHelloMinimumSize);
 
   crypto_test_utils::GenerateFullCHLO(
       inchoate_chlo, &crypto_config, server_addr, client_addr, version, &clock,
       signed_config, &compressed_certs_cache, &full_chlo);
   // Verify that full_chlo can pass crypto_config's verification.
   ShloVerifier shlo_verifier(&crypto_config, server_addr, client_addr, &clock,
                              signed_config, &compressed_certs_cache);
   crypto_config.ValidateClientHello(
       full_chlo, client_addr.host(), server_addr, version, &clock,
       signed_config, shlo_verifier.GetValidateClientHelloCallback());
 }
 
 }  // namespace test
 }  // namespace net