Compile several targets in Gallery in gyp v2.

Compile several targets in Gallery in gyp v2.

Renamed ImageUtil.metrics to metrics so that metrics users don't necessarily
depend on ImageUtil.
Split ImageLoader from image_util.js into a separated file.
Added externs/gallery_event.js to compile ribbon.js.

BUG=636289
TEST=run_compiler, git cl try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2678723002
Cr-Commit-Position: refs/heads/master@{#452430}
Committed: https://chromium.googlesource.com/chromium/src/+/9f9e4d69ac5649f7c5b842fbf271b9c2650aef44

[oka, 2017-02-06 05:05:11]

Description was changed from

==========
Compile Gallery.

BUG=636289
TEST=TBD
==========

to

==========
Compile Gallery.

BUG=636289
TEST=TBD
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-02-20 09:41:00]

.

[oka, 2017-02-20 09:51:37]

Description was changed from

==========
Compile Gallery.

BUG=636289
TEST=TBD
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile several targets in Gallery in gyp v2.

Renamed ImageUtil.metrics to metrics so that metrics users don't necessarily
depend on ImageUtil.
Split ImageLoader from image_util.js into a separated file.
Added externs/gallery_event.js to compile ribbon.js.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-02-20 09:52:31]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2017-02-20 09:52:31]

PTAL.

[oka, 2017-02-20 09:53:13]

Description was changed from

==========
Compile several targets in Gallery in gyp v2.

Renamed ImageUtil.metrics to metrics so that metrics users don't necessarily
depend on ImageUtil.
Split ImageLoader from image_util.js into a separated file.
Added externs/gallery_event.js to compile ribbon.js.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile several targets in Gallery in gyp v2.

Renamed ImageUtil.metrics to metrics so that metrics users don't necessarily
depend on ImageUtil.
Split ImageLoader from image_util.js into a separated file.
Added externs/gallery_event.js to compile ribbon.js.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-02-20 09:53:53]

oka@chromium.org changed reviewers:
+ dbeam@chromium.org

[oka, 2017-02-20 09:53:54]

PTAL.
dbeam@ for ui/webui/resources/js/cr/ui/compiled_resources2.gyp
fukino@ for others.

[oka, 2017-02-20 11:02:28]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 11:02:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 12:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 12:42:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2017-02-20 22:46:36]

oka@chromium.org changed reviewers:
- dbeam@chromium.org, fukino@chromium.org

[oka, 2017-02-20 22:46:37]

Sorry, I saw tests failures. I'll fix them and send review requeste again.

[oka, 2017-02-22 11:38:06]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 11:38:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 12:16:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 12:16:19]

Dry run: This issue passed the CQ dry run.

[oka, 2017-02-22 14:01:09]

oka@chromium.org changed reviewers:
+ dbeam@chromium.org, fukino@chromium.org

[oka, 2017-02-22 14:01:36]

Description was changed from

==========
Compile several targets in Gallery in gyp v2.

Renamed ImageUtil.metrics to metrics so that metrics users don't necessarily
depend on ImageUtil.
Split ImageLoader from image_util.js into a separated file.
Added externs/gallery_event.js to compile ribbon.js.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile several targets in Gallery in gyp v2.

Renamed ImageUtil.metrics to metrics so that metrics users don't necessarily
depend on ImageUtil.
Split ImageLoader from image_util.js into a separated file.
Added externs/gallery_event.js to compile ribbon.js.

BUG=636289
TEST=run_compiler, git cl try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-02-22 14:01:46]

PTAL.
dbeam@ for ui/webui/resources/js/cr/ui/compiled_resources2.gyp
fukino@ for others.

[Dan Beam, 2017-02-23 05:10:30]

sweeet! lgtm

also, you should sync past this change:
https://codereview.chromium.org/2712893002/

should make your local compile much faster

[fukino, 2017-02-23 05:35:39]

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/externs...
File ui/file_manager/externs/gallery_event.js (right):

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/externs...
ui/file_manager/externs/gallery_event.js:6: * @type{Entry}
nit: space after @type

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/externs...
ui/file_manager/externs/gallery_event.js:8: Event.prototype.oldEntry;
Could you name it as GalleryEvent instead of extending all Events?

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/externs...
ui/file_manager/externs/gallery_event.js:11: * @type{GalleryItem}
ditto

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/gallery...
File ui/file_manager/gallery/js/compiled_resources.gyp (right):

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/gallery...
ui/file_manager/gallery/js/compiled_resources.gyp:127:
'./image_editor/image_loader.js',
sort

[oka, 2017-02-23 05:57:46]

Addressed comments

[oka, 2017-02-23 06:02:31]

PTAL.

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/externs...
File ui/file_manager/externs/gallery_event.js (right):

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/externs...
ui/file_manager/externs/gallery_event.js:6: * @type{Entry}
On 2017/02/23 05:35:39, fukino wrote:
> nit: space after @type

Done.

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/externs...
ui/file_manager/externs/gallery_event.js:8: Event.prototype.oldEntry;
On 2017/02/23 05:35:39, fukino wrote:
> Could you name it as GalleryEvent instead of extending all Events?

Done.

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/externs...
ui/file_manager/externs/gallery_event.js:11: * @type{GalleryItem}
On 2017/02/23 05:35:39, fukino wrote:
> ditto

Done.

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/gallery...
File ui/file_manager/gallery/js/compiled_resources.gyp (right):

https://codereview.chromium.org/2678723002/diff/40001/ui/file_manager/gallery...
ui/file_manager/gallery/js/compiled_resources.gyp:127:
'./image_editor/image_loader.js',
On 2017/02/23 05:35:39, fukino wrote:
> sort

It seems order matters in gyp. I'd rather keep this as is.

[oka, 2017-02-23 06:02:45]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 06:03:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fukino, 2017-02-23 06:17:56]

lgtm, thanks!
(but please make sure the metrics is logged as before in the new code)

[oka, 2017-02-23 06:19:58]

The CQ bit was checked by oka@chromium.org

[oka, 2017-02-23 06:19:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2678723002/#ps60001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-02-23 06:20:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 06:41:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 06:41:05]

Failed to apply patch for ui/file_manager/compiled_resources2.gyp:
While running git apply --index -p1;
  error: patch failed: ui/file_manager/compiled_resources2.gyp:15
  error: ui/file_manager/compiled_resources2.gyp: patch does not apply

Patch:       ui/file_manager/compiled_resources2.gyp
Index: ui/file_manager/compiled_resources2.gyp
diff --git a/ui/file_manager/compiled_resources2.gyp
b/ui/file_manager/compiled_resources2.gyp
index
5ea03a675953a1d87b4ff5f5ea3c6d669e1df435..c69f8f9dbe7bae0f5db3cac8b96671813e49a12e
100644
--- a/ui/file_manager/compiled_resources2.gyp
+++ b/ui/file_manager/compiled_resources2.gyp
@@ -15,6 +15,7 @@
         'file_manager/foreground/js/compiled_resources2.gyp:*',
         'file_manager/foreground/js/metadata/compiled_resources2.gyp:*',
         'gallery/js/compiled_resources2.gyp:*',
+        'gallery/js/image_editor/compiled_resources2.gyp:*',
         'image_loader/compiled_resources2.gyp:*',
         'video_player/js/compiled_resources2.gyp:*',
       ],

[oka, 2017-02-23 06:46:55]

Rebased.

[oka, 2017-02-23 07:31:14]

The CQ bit was checked by oka@chromium.org

[oka, 2017-02-23 07:31:14]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2678723002/#ps80001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-02-23 07:31:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 08:08:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487835074122210,
"parent_rev": "a1dc9e1b9118c1402fe7981f1d5e1fcbbb023c00", "commit_rev":
"9f9e4d69ac5649f7c5b842fbf271b9c2650aef44"}

[commit-bot: I haz the power, 2017-02-23 08:09:29]

Description was changed from

==========
Compile several targets in Gallery in gyp v2.

Renamed ImageUtil.metrics to metrics so that metrics users don't necessarily
depend on ImageUtil.
Split ImageLoader from image_util.js into a separated file.
Added externs/gallery_event.js to compile ribbon.js.

BUG=636289
TEST=run_compiler, git cl try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile several targets in Gallery in gyp v2.

Renamed ImageUtil.metrics to metrics so that metrics users don't necessarily
depend on ImageUtil.
Split ImageLoader from image_util.js into a separated file.
Added externs/gallery_event.js to compile ribbon.js.

BUG=636289
TEST=run_compiler, git cl try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2678723002
Cr-Commit-Position: refs/heads/master@{#452430}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f9e4d69ac5649f7c5b842fbf271...
==========

[commit-bot: I haz the power, 2017-02-23 08:09:30]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9f9e4d69ac5649f7c5b842fbf271...

[oka, 2017-02-23 11:07:26]

On 2017/02/23 06:17:56, fukino wrote:
> lgtm, thanks!
> (but please make sure the metrics is logged as before in the new code)

I checked metrics are exprted as before to chrome://histograms.