Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1966)

Unified Diff: ui/file_manager/gallery/js/compiled_resources2.gyp

Issue 2678723002: Compile several targets in Gallery in gyp v2. (Closed)
Patch Set: Rebased. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/gallery/js/compiled_resources.gyp ('k') | ui/file_manager/gallery/js/gallery.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/gallery/js/compiled_resources2.gyp
diff --git a/ui/file_manager/gallery/js/compiled_resources2.gyp b/ui/file_manager/gallery/js/compiled_resources2.gyp
index ce842523bdc22dc73cea687c58ab06a4378c2791..1f7eb261ea9610fec6049d44ce810f114c22192e 100644
--- a/ui/file_manager/gallery/js/compiled_resources2.gyp
+++ b/ui/file_manager/gallery/js/compiled_resources2.gyp
@@ -1,6 +1,7 @@
# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+# TODO(oka): Compile all the targets.
{
'targets': [
# {
@@ -15,44 +16,97 @@
# 'target_name': 'entry_list_watcher',
# 'includes': ['../../compile_js2.gypi'],
# },
-# {
-# 'target_name': 'error_banner',
-# 'includes': ['../../compile_js2.gypi'],
-# },
+ {
+ 'target_name': 'error_banner',
+ 'dependencies': [
+ '../../file_manager/common/js/compiled_resources2.gyp:util',
+ ],
+ 'includes': ['../../compile_js2.gypi'],
+ },
# {
# 'target_name': 'gallery',
# 'includes': ['../../compile_js2.gypi'],
# },
# {
# 'target_name': 'gallery_data_model',
+# 'dependencies': [
+# 'thumbnail_mode',
+# '../../file_manager/common/js/compiled_resources2.gyp:util',
+# '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',
+# 'gallery_item',
+# '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:array_data_model',
+# ],
# 'includes': ['../../compile_js2.gypi'],
# },
-# {
-# 'target_name': 'gallery_item',
-# 'includes': ['../../compile_js2.gypi'],
-# },
+ {
+ 'target_name': 'gallery_item',
+ 'dependencies': [
+ '../../file_manager/common/js/compiled_resources2.gyp:util',
+ '../../file_manager/foreground/js/compiled_resources2.gyp:volume_manager_wrapper',
+ '../../file_manager/foreground/js/metadata/compiled_resources2.gyp:metadata_model',
+ '../../file_manager/foreground/js/metadata/compiled_resources2.gyp:thumbnail_model',
+ 'gallery_util',
+ 'image_editor/compiled_resources2.gyp:image_encoder',
+ 'image_editor/compiled_resources2.gyp:image_util',
+ ],
+ 'includes': ['../../compile_js2.gypi'],
+ },
# {
# 'target_name': 'gallery_scripts',
# 'includes': ['../../compile_js2.gypi'],
# },
-# {
-# 'target_name': 'gallery_util',
-# 'includes': ['../../compile_js2.gypi'],
-# },
-# {
-# 'target_name': 'metadata_worker',
-# 'includes': ['../../compile_js2.gypi'],
-# },
-# {
-# 'target_name': 'ribbon',
-# 'includes': ['../../compile_js2.gypi'],
-# },
+ {
+ 'target_name': 'gallery_util',
+ 'dependencies': [
+ '../../file_manager/common/js/compiled_resources2.gyp:file_type',
+ '../../file_manager/common/js/compiled_resources2.gyp:util',
+ '../../file_manager/common/js/compiled_resources2.gyp:volume_manager_common',
+ '../../file_manager/foreground/js/compiled_resources2.gyp:volume_manager_wrapper',
+ ],
+ 'includes': ['../../compile_js2.gypi'],
+ },
+ {
+ 'target_name': 'metadata_worker',
+ 'includes': ['../../compile_js2.gypi'],
+ },
+ {
+ 'target_name': 'ribbon',
+ 'dependencies': [
+ '../../externs/compiled_resources2.gyp:gallery_event',
+ '../../file_manager/foreground/js/compiled_resources2.gyp:thumbnail_loader',
+ '../../file_manager/foreground/js/metadata/compiled_resources2.gyp:thumbnail_model',
+ '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:array_data_model',
+ '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:list_selection_model',
+ 'gallery_item',
+ 'image_editor/compiled_resources2.gyp:image_util',
+ ],
+ 'includes': ['../../compile_js2.gypi'],
+ },
# {
# 'target_name': 'slide_mode',
+# 'dependencies': [
+# '../../file_manager/common/js/compiled_resources2.gyp:metrics',
+# '../../file_manager/common/js/compiled_resources2.gyp:util',
+# '<(EXTERNS_GYP):chrome_extensions',
+# 'gallery_item',
+# 'image_editor/compiled_resources2.gyp:image_editor',
+# 'image_editor/compiled_resources2.gyp:image_util',
+# 'image_editor/compiled_resources2.gyp:image_view',
+# 'image_editor/compiled_resources2.gyp:viewport',
+# ],
# 'includes': ['../../compile_js2.gypi'],
# },
# {
# 'target_name': 'thumbnail_mode',
+# 'dependencies': [
+# '../../file_manager/foreground/js/compiled_resources2.gyp:thumbnail_loader',
+# '../../file_manager/foreground/js/metadata/compiled_resources2.gyp:thumbnail_model',
+# '<(DEPTH)/ui/webui/resources/js/cr/ui/compiled_resources2.gyp:list_selection_model',
+# 'error_banner',
+# 'gallery_data_model',
+# 'gallery_item',
+# 'image_editor/compiled_resources2.gyp:image_editor',
+# ],
# 'includes': ['../../compile_js2.gypi'],
# },
],
« no previous file with comments | « ui/file_manager/gallery/js/compiled_resources.gyp ('k') | ui/file_manager/gallery/js/gallery.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698