Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: ui/file_manager/gallery/js/slide_mode.js

Issue 2678723002: Compile several targets in Gallery in gyp v2. (Closed)
Patch Set: Rebased. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/gallery/js/slide_mode.js
diff --git a/ui/file_manager/gallery/js/slide_mode.js b/ui/file_manager/gallery/js/slide_mode.js
index 12e1885a18898c5f8783c50594836b0af1faa8b7..75df0b37056b25d23856c2824fdcb91e07829268 100644
--- a/ui/file_manager/gallery/js/slide_mode.js
+++ b/ui/file_manager/gallery/js/slide_mode.js
@@ -1039,7 +1039,7 @@ SlideMode.prototype.itemLoaded_ = function(
this.errorBanner_.show('GALLERY_IMAGE_OFFLINE');
}
- ImageUtil.metrics.recordUserAction(ImageUtil.getMetricName('View'));
+ metrics.recordUserAction(ImageUtil.getMetricName('View'));
var toMillions = function(number) {
return Math.round(number / (1000 * 1000));
@@ -1047,19 +1047,19 @@ SlideMode.prototype.itemLoaded_ = function(
var metadata = item.getMetadataItem();
if (metadata) {
- ImageUtil.metrics.recordSmallCount(ImageUtil.getMetricName('Size.MB'),
+ metrics.recordSmallCount(ImageUtil.getMetricName('Size.MB'),
toMillions(metadata.size));
}
var image = this.imageView_.getImage();
- ImageUtil.metrics.recordSmallCount(ImageUtil.getMetricName('Size.MPix'),
+ metrics.recordSmallCount(ImageUtil.getMetricName('Size.MPix'),
toMillions(image.width * image.height));
var extIndex = entry.name.lastIndexOf('.');
var ext = extIndex < 0 ? '' :
entry.name.substr(extIndex + 1).toLowerCase();
if (ext === 'jpeg') ext = 'jpg';
- ImageUtil.metrics.recordEnum(
+ metrics.recordEnum(
ImageUtil.getMetricName('FileType'), ext, ImageUtil.FILE_TYPES);
// Enable or disable buttons for editing and printing.
@@ -1318,7 +1318,7 @@ SlideMode.prototype.saveCurrentImage_ = function(item, callback) {
// Record UMA for the first edit.
if (this.imageView_.getContentRevision() === 1)
- ImageUtil.metrics.recordUserAction(ImageUtil.getMetricName('Edit'));
+ metrics.recordUserAction(ImageUtil.getMetricName('Edit'));
// Users can change overwrite original setting only if there is no undo
// stack and item is original and writable.
« no previous file with comments | « ui/file_manager/gallery/js/image_editor/image_view.js ('k') | ui/webui/resources/js/cr/ui/compiled_resources2.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698