Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 2678483003: Fix EXT_draw_buffers detection on some GL ES 3 contexts (Closed)
Patch Set: update tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/feature_info_unittest.cc
diff --git a/gpu/command_buffer/service/feature_info_unittest.cc b/gpu/command_buffer/service/feature_info_unittest.cc
index 902a9531acd6e7a3155570dbe44524ce551d27e6..e454bcc0bbfb307976fa986e6591d4784b336195 100644
--- a/gpu/command_buffer/service/feature_info_unittest.cc
+++ b/gpu/command_buffer/service/feature_info_unittest.cc
@@ -1529,15 +1529,17 @@ TEST_P(FeatureInfoTest, InitializeWithNVFence) {
TEST_P(FeatureInfoTest, InitializeWithNVDrawBuffers) {
SetupInitExpectationsWithGLVersion("GL_NV_draw_buffers", "", "OpenGL ES 3.0");
- EXPECT_TRUE(info_->feature_flags().nv_draw_buffers);
- EXPECT_TRUE(info_->feature_flags().ext_draw_buffers);
+ bool is_es2 = GetContextType() == CONTEXT_TYPE_OPENGLES2;
+ EXPECT_EQ(is_es2, info_->feature_flags().nv_draw_buffers);
+ EXPECT_EQ(is_es2, info_->feature_flags().ext_draw_buffers);
}
TEST_P(FeatureInfoTest, InitializeWithPreferredEXTDrawBuffers) {
SetupInitExpectationsWithGLVersion(
"GL_NV_draw_buffers GL_EXT_draw_buffers", "", "OpenGL ES 3.0");
+ bool is_es2 = GetContextType() == CONTEXT_TYPE_OPENGLES2;
EXPECT_FALSE(info_->feature_flags().nv_draw_buffers);
- EXPECT_TRUE(info_->feature_flags().ext_draw_buffers);
+ EXPECT_EQ(is_es2, info_->feature_flags().ext_draw_buffers);
}
TEST_P(FeatureInfoTest, BlendEquationAdvancedDisabled) {

Powered by Google App Engine
This is Rietveld 408576698