Pass Callback by value on PostTaskAndReply family

Pass Callback by value on PostTaskAndReply family

This is a less controversial part of OnceCallback migration of PostTaskAndReply.
https://codereview.chromium.org/2657603004/

After this CL PostTaskAndReply family take the callback by value, and
move it to their storage. That reduces the chance to leave a reference
to the callback on the original thread.

Review-Url: https://codereview.chromium.org/2678303002
Cr-Commit-Position: refs/heads/master@{#448965}
Committed: https://chromium.googlesource.com/chromium/src/+/03527510144419d0b9b7b8f0c31c4c199f93a18c

[tzik, 2017-02-07 07:45:23]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 07:45:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-02-07 07:51:23]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 07:51:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-02-07 07:58:55]

Description was changed from

==========
Pass Callback by value on PostTaskAndReply family
==========

to

==========
Pass Callback by value on PostTaskAndReply family

This is a less controversial part of OnceCallback migration of PostTaskAndReply.
https://codereview.chromium.org/2657603004/

After this CL PostTaskAndReply family take the callback by value, and
move it to their storage. That reduces the chance to leave a reference
to the callback on the original thread.
==========

[tzik, 2017-02-07 07:58:55]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org, gab@chromium.org

[tzik, 2017-02-07 07:59:11]

PTAL

[dcheng, 2017-02-07 08:01:48]

Any chance you can upload this PS to the other review? It'll make it easier to
diff.

[tzik, 2017-02-07 08:39:07]

On 2017/02/07 08:01:48, dcheng wrote:
> Any chance you can upload this PS to the other review? It'll make it easier to
> diff.

Rebased the other CL onto this CL, that should make similar diff to that.

[dcheng, 2017-02-07 09:27:37]

lgtm

[commit-bot: I haz the power, 2017-02-07 09:42:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 09:42:51]

Dry run: This issue passed the CQ dry run.

[gab, 2017-02-07 15:46:08]

lgtm % missing <utility> includes (note: that's a really annoying IWYU
side-effect of std::move :(...)

https://codereview.chromium.org/2678303002/diff/20001/base/task_runner.cc
File base/task_runner.cc (right):

https://codereview.chromium.org/2678303002/diff/20001/base/task_runner.cc#new...
base/task_runner.cc:52: from_here, std::move(task), std::move(reply));
#include <utility>

for std::move

https://codereview.chromium.org/2678303002/diff/20001/base/task_runner_util.h
File base/task_runner_util.h (right):

https://codereview.chromium.org/2678303002/diff/20001/base/task_runner_util.h...
base/task_runner_util.h:43: std::move(reply), base::Owned(result)));
#include <utility>

https://codereview.chromium.org/2678303002/diff/20001/base/task_scheduler/pos...
File base/task_scheduler/post_task.h (right):

https://codereview.chromium.org/2678303002/diff/20001/base/task_scheduler/pos...
base/task_scheduler/post_task.h:97: std::move(reply));
#include <utility>

https://codereview.chromium.org/2678303002/diff/20001/base/threading/post_tas...
File base/threading/post_task_and_reply_impl.cc (right):

https://codereview.chromium.org/2678303002/diff/20001/base/threading/post_tas...
base/threading/post_task_and_reply_impl.cc:36: task_(std::move(task)) {}
#include <utility>

https://codereview.chromium.org/2678303002/diff/20001/base/threading/worker_p...
File base/threading/worker_pool.cc (right):

https://codereview.chromium.org/2678303002/diff/20001/base/threading/worker_p...
base/threading/worker_pool.cc:113: .PostTaskAndReply(from_here, std::move(task),
std::move(reply));
#include <utility>

https://codereview.chromium.org/2678303002/diff/20001/content/browser/browser...
File content/browser/browser_thread_impl.cc (right):

https://codereview.chromium.org/2678303002/diff/20001/content/browser/browser...
content/browser/browser_thread_impl.cc:544: from_here, std::move(task),
std::move(reply));
#include <utility>

https://codereview.chromium.org/2678303002/diff/20001/content/public/browser/...
File content/public/browser/browser_thread.h (right):

https://codereview.chromium.org/2678303002/diff/20001/content/public/browser/...
content/public/browser/browser_thread.h:136: std::move(task), std::move(reply));
#include <utility>

https://codereview.chromium.org/2678303002/diff/20001/ios/web/public/web_thre...
File ios/web/public/web_thread.h (right):

https://codereview.chromium.org/2678303002/diff/20001/ios/web/public/web_thre...
ios/web/public/web_thread.h:131: std::move(task), std::move(reply));
#include <utility>

https://codereview.chromium.org/2678303002/diff/20001/ios/web/web_thread_impl.cc
File ios/web/web_thread_impl.cc (right):

https://codereview.chromium.org/2678303002/diff/20001/ios/web/web_thread_impl...
ios/web/web_thread_impl.cc:341: from_here, std::move(task), std::move(reply));
#include <utility>

[tzik, 2017-02-08 01:39:31]

tzik@chromium.org changed reviewers:
+ kinuko@chromium.org, marq@chromium.org

[tzik, 2017-02-08 01:39:33]

Adding marq and kinuko for OWNERS review. PTAL to:
marq: //ios/web
kinuko: //content and //storage

https://codereview.chromium.org/2678303002/diff/20001/base/task_runner.cc
File base/task_runner.cc (right):

https://codereview.chromium.org/2678303002/diff/20001/base/task_runner.cc#new...
base/task_runner.cc:52: from_here, std::move(task), std::move(reply));
On 2017/02/07 15:46:08, gab wrote:
> #include <utility>
> 
> for std::move

Done.

https://codereview.chromium.org/2678303002/diff/20001/base/task_runner_util.h
File base/task_runner_util.h (right):

https://codereview.chromium.org/2678303002/diff/20001/base/task_runner_util.h...
base/task_runner_util.h:43: std::move(reply), base::Owned(result)));
On 2017/02/07 15:46:08, gab wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2678303002/diff/20001/base/task_scheduler/pos...
File base/task_scheduler/post_task.h (right):

https://codereview.chromium.org/2678303002/diff/20001/base/task_scheduler/pos...
base/task_scheduler/post_task.h:97: std::move(reply));
On 2017/02/07 15:46:08, gab wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2678303002/diff/20001/base/threading/post_tas...
File base/threading/post_task_and_reply_impl.cc (right):

https://codereview.chromium.org/2678303002/diff/20001/base/threading/post_tas...
base/threading/post_task_and_reply_impl.cc:36: task_(std::move(task)) {}
On 2017/02/07 15:46:08, gab wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2678303002/diff/20001/base/threading/worker_p...
File base/threading/worker_pool.cc (right):

https://codereview.chromium.org/2678303002/diff/20001/base/threading/worker_p...
base/threading/worker_pool.cc:113: .PostTaskAndReply(from_here, std::move(task),
std::move(reply));
On 2017/02/07 15:46:08, gab wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2678303002/diff/20001/content/browser/browser...
File content/browser/browser_thread_impl.cc (right):

https://codereview.chromium.org/2678303002/diff/20001/content/browser/browser...
content/browser/browser_thread_impl.cc:544: from_here, std::move(task),
std::move(reply));
On 2017/02/07 15:46:08, gab wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2678303002/diff/20001/content/public/browser/...
File content/public/browser/browser_thread.h (right):

https://codereview.chromium.org/2678303002/diff/20001/content/public/browser/...
content/public/browser/browser_thread.h:136: std::move(task), std::move(reply));
On 2017/02/07 15:46:08, gab wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2678303002/diff/20001/ios/web/public/web_thre...
File ios/web/public/web_thread.h (right):

https://codereview.chromium.org/2678303002/diff/20001/ios/web/public/web_thre...
ios/web/public/web_thread.h:131: std::move(task), std::move(reply));
On 2017/02/07 15:46:08, gab wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2678303002/diff/20001/ios/web/web_thread_impl.cc
File ios/web/web_thread_impl.cc (right):

https://codereview.chromium.org/2678303002/diff/20001/ios/web/web_thread_impl...
ios/web/web_thread_impl.cc:341: from_here, std::move(task), std::move(reply));
On 2017/02/07 15:46:08, gab wrote:
> #include <utility>

Done.

[kinuko, 2017-02-08 03:57:16]

> kinuko: //content and //storage

lgtm

[marq (ping after 24h), 2017-02-08 08:14:18]

ios/ LGTM

[tzik, 2017-02-08 08:24:12]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-02-08 08:24:13]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2678303002/#ps40001
(title: "+#include <utility>")

[commit-bot: I haz the power, 2017-02-08 08:24:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 10:38:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 10:38:53]

Failed to apply patch for storage/browser/quota/quota_manager.h:
While running git apply --index -p1;
  error: patch failed: storage/browser/quota/quota_manager.h:449
  error: storage/browser/quota/quota_manager.h: patch does not apply

Patch:       storage/browser/quota/quota_manager.h
Index: storage/browser/quota/quota_manager.h
diff --git a/storage/browser/quota/quota_manager.h
b/storage/browser/quota/quota_manager.h
index
a1ef11d2a55fbdeb64aa37463f469d6fa92ef775..483c9ea6fe1289847af7f7446aa69db46530d06c
100644
--- a/storage/browser/quota/quota_manager.h
+++ b/storage/browser/quota/quota_manager.h
@@ -449,8 +449,8 @@ class STORAGE_EXPORT QuotaManager
 
   void PostTaskAndReplyWithResultForDBThread(
       const tracked_objects::Location& from_here,
-      const base::Callback<bool(QuotaDatabase*)>& task,
-      const base::Callback<void(bool)>& reply);
+      base::Callback<bool(QuotaDatabase*)> task,
+      base::Callback<void(bool)> reply);
 
   static int64_t CallGetAmountOfFreeDiskSpace(
       GetVolumeInfoFn get_vol_info_fn,

[tzik, 2017-02-08 11:00:18]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-02-08 11:00:18]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
gab@chromium.org, dcheng@chromium.org, marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2678303002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-08 11:00:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 12:29:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486551618481050,
"parent_rev": "9b6acec18fdd1e35921ca18501b5dfd002e1ce4c", "commit_rev":
"03527510144419d0b9b7b8f0c31c4c199f93a18c"}

[commit-bot: I haz the power, 2017-02-08 12:30:31]

Description was changed from

==========
Pass Callback by value on PostTaskAndReply family

This is a less controversial part of OnceCallback migration of PostTaskAndReply.
https://codereview.chromium.org/2657603004/

After this CL PostTaskAndReply family take the callback by value, and
move it to their storage. That reduces the chance to leave a reference
to the callback on the original thread.
==========

to

==========
Pass Callback by value on PostTaskAndReply family

This is a less controversial part of OnceCallback migration of PostTaskAndReply.
https://codereview.chromium.org/2657603004/

After this CL PostTaskAndReply family take the callback by value, and
move it to their storage. That reduces the chance to leave a reference
to the callback on the original thread.

Review-Url: https://codereview.chromium.org/2678303002
Cr-Commit-Position: refs/heads/master@{#448965}
Committed:
https://chromium.googlesource.com/chromium/src/+/03527510144419d0b9b7b8f0c31c...
==========

[commit-bot: I haz the power, 2017-02-08 12:30:33]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/03527510144419d0b9b7b8f0c31c...