Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: content/browser/browser_thread_impl.cc

Issue 2678303002: Pass Callback by value on PostTaskAndReply family (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/worker_pool.cc ('k') | content/public/browser/browser_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_thread_impl.cc
diff --git a/content/browser/browser_thread_impl.cc b/content/browser/browser_thread_impl.cc
index 2b89f6d15f9e9863f3af1e6318b8725cd0b0396e..895fba219d74d755af9da7bd47394e3e62351e4d 100644
--- a/content/browser/browser_thread_impl.cc
+++ b/content/browser/browser_thread_impl.cc
@@ -5,6 +5,7 @@
#include "content/browser/browser_thread_impl.h"
#include <string>
+#include <utility>
#include "base/atomicops.h"
#include "base/bind.h"
@@ -538,10 +539,10 @@ bool BrowserThread::PostBlockingPoolTask(
// static
bool BrowserThread::PostBlockingPoolTaskAndReply(
const tracked_objects::Location& from_here,
- const base::Closure& task,
- const base::Closure& reply) {
+ base::Closure task,
+ base::Closure reply) {
return g_globals.Get().blocking_pool->PostTaskAndReply(
- from_here, task, reply);
+ from_here, std::move(task), std::move(reply));
}
// static
@@ -653,13 +654,12 @@ bool BrowserThread::PostNonNestableDelayedTask(
}
// static
-bool BrowserThread::PostTaskAndReply(
- ID identifier,
- const tracked_objects::Location& from_here,
- const base::Closure& task,
- const base::Closure& reply) {
+bool BrowserThread::PostTaskAndReply(ID identifier,
+ const tracked_objects::Location& from_here,
+ base::Closure task,
+ base::Closure reply) {
return GetTaskRunnerForThread(identifier)
- ->PostTaskAndReply(from_here, task, reply);
+ ->PostTaskAndReply(from_here, std::move(task), std::move(reply));
}
// static
« no previous file with comments | « base/threading/worker_pool.cc ('k') | content/public/browser/browser_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698