Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: base/task_runner.cc

Issue 2678303002: Pass Callback by value on PostTaskAndReply family (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/task_runner.h ('k') | base/task_runner_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_runner.h" 5 #include "base/task_runner.h"
6 6
7 #include <utility>
8
7 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
8 #include "base/logging.h" 10 #include "base/logging.h"
9 #include "base/threading/post_task_and_reply_impl.h" 11 #include "base/threading/post_task_and_reply_impl.h"
10 12
11 namespace base { 13 namespace base {
12 14
13 namespace { 15 namespace {
14 16
15 // TODO(akalin): There's only one other implementation of 17 // TODO(akalin): There's only one other implementation of
16 // PostTaskAndReplyImpl in WorkerPool. Investigate whether it'll be 18 // PostTaskAndReplyImpl in WorkerPool. Investigate whether it'll be
(...skipping 21 matching lines...) Expand all
38 return destination_->PostTask(from_here, task); 40 return destination_->PostTask(from_here, task);
39 } 41 }
40 42
41 } // namespace 43 } // namespace
42 44
43 bool TaskRunner::PostTask(const tracked_objects::Location& from_here, 45 bool TaskRunner::PostTask(const tracked_objects::Location& from_here,
44 const Closure& task) { 46 const Closure& task) {
45 return PostDelayedTask(from_here, task, base::TimeDelta()); 47 return PostDelayedTask(from_here, task, base::TimeDelta());
46 } 48 }
47 49
48 bool TaskRunner::PostTaskAndReply( 50 bool TaskRunner::PostTaskAndReply(const tracked_objects::Location& from_here,
49 const tracked_objects::Location& from_here, 51 Closure task,
50 const Closure& task, 52 Closure reply) {
51 const Closure& reply) {
52 return PostTaskAndReplyTaskRunner(this).PostTaskAndReply( 53 return PostTaskAndReplyTaskRunner(this).PostTaskAndReply(
53 from_here, task, reply); 54 from_here, std::move(task), std::move(reply));
54 } 55 }
55 56
56 TaskRunner::TaskRunner() {} 57 TaskRunner::TaskRunner() {}
57 58
58 TaskRunner::~TaskRunner() {} 59 TaskRunner::~TaskRunner() {}
59 60
60 void TaskRunner::OnDestruct() const { 61 void TaskRunner::OnDestruct() const {
61 delete this; 62 delete this;
62 } 63 }
63 64
64 void TaskRunnerTraits::Destruct(const TaskRunner* task_runner) { 65 void TaskRunnerTraits::Destruct(const TaskRunner* task_runner) {
65 task_runner->OnDestruct(); 66 task_runner->OnDestruct();
66 } 67 }
67 68
68 } // namespace base 69 } // namespace base
OLDNEW
« no previous file with comments | « base/task_runner.h ('k') | base/task_runner_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698